From 0e933d6760635bea076d3080f36d46bb0a0b23f9 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 11 Aug 2023 09:20:01 -0400 Subject: [PATCH] Fix logging because not all items are issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:56 Processing the batch of issues #1 containing 3 issues... ::group::[#3] Pull request #3 [#3] Pull request #3 ... ::group::[#2] Issue #2 [#2] Issue #2 ... ::group::[#1] Issue #1 [#1] Issue #1 ... Batch #1 processed. No more issues found to process. Exiting... Statistics: Processed items: 3 ├── Processed issues: 2 └── Processed PRs : 1 Clearly this action sometimes understands that users do not view all items as issues. This change applies the `items` nomenclature to this initial logging. --- dist/index.js | 12 ++++++------ src/classes/issues-processor.ts | 14 +++++++------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dist/index.js b/dist/index.js index ab1b84c3..29b63ad9 100644 --- a/dist/index.js +++ b/dist/index.js @@ -425,16 +425,16 @@ class IssuesProcessor { processIssues(page = 1) { var _a, _b; return __awaiter(this, void 0, void 0, function* () { - // get the next batch of issues + // get the next batch of items const issues = yield this.getIssues(page); if (issues.length <= 0) { - this._logger.info(logger_service_1.LoggerService.green(`No more issues found to process. Exiting...`)); + this._logger.info(logger_service_1.LoggerService.green(`No more items found to process. Exiting...`)); (_a = this.statistics) === null || _a === void 0 ? void 0 : _a.setOperationsCount(this.operations.getConsumedOperationsCount()).logStats(); this.state.reset(); return this.operations.getRemainingOperationsCount(); } else { - this._logger.info(`${logger_service_1.LoggerService.yellow('Processing the batch of issues ')} ${logger_service_1.LoggerService.cyan(`#${page}`)} ${logger_service_1.LoggerService.yellow(' containing ')} ${logger_service_1.LoggerService.cyan(issues.length)} ${logger_service_1.LoggerService.yellow(` issue${issues.length > 1 ? 's' : ''}...`)}`); + this._logger.info(`${logger_service_1.LoggerService.yellow('Processing the batch of items ')} ${logger_service_1.LoggerService.cyan(`#${page}`)} ${logger_service_1.LoggerService.yellow(' containing ')} ${logger_service_1.LoggerService.cyan(issues.length)} ${logger_service_1.LoggerService.yellow(` item${issues.length > 1 ? 's' : ''}...`)}`); } const labelsToRemoveWhenStale = (0, words_to_list_1.wordsToList)(this.options.labelsToRemoveWhenStale); const labelsToAddWhenUnstale = (0, words_to_list_1.wordsToList)(this.options.labelsToAddWhenUnstale); @@ -456,7 +456,7 @@ class IssuesProcessor { } if (!this.operations.hasRemainingOperations()) { this._logger.warning(logger_service_1.LoggerService.yellowBright(`No more operations left! Exiting...`)); - this._logger.warning(`${logger_service_1.LoggerService.yellowBright('If you think that not enough issues were processed you could try to increase the quantity related to the ')} ${this._logger.createOptionLink(option_1.Option.OperationsPerRun)} ${logger_service_1.LoggerService.yellowBright(' option which is currently set to ')} ${logger_service_1.LoggerService.cyan(this.options.operationsPerRun)}`); + this._logger.warning(`${logger_service_1.LoggerService.yellowBright('If you think that not enough items were processed you could try to increase the quantity related to the ')} ${this._logger.createOptionLink(option_1.Option.OperationsPerRun)} ${logger_service_1.LoggerService.yellowBright(' option which is currently set to ')} ${logger_service_1.LoggerService.cyan(this.options.operationsPerRun)}`); (_b = this.statistics) === null || _b === void 0 ? void 0 : _b.setOperationsCount(this.operations.getConsumedOperationsCount()).logStats(); return 0; } @@ -667,7 +667,7 @@ class IssuesProcessor { return comments.data; } catch (error) { - this._logger.error(`List issue comments error: ${error.message}`); + this._logger.error(`List $$type comments error: ${error.message}`); return Promise.resolve([]); } }); @@ -690,7 +690,7 @@ class IssuesProcessor { return issueResult.data.map((issue) => new issue_1.Issue(this.options, issue)); } catch (error) { - throw Error(`Getting issues was blocked by the error: ${error.message}`); + throw Error(`Getting items was blocked by the error: ${error.message}`); } }); } diff --git a/src/classes/issues-processor.ts b/src/classes/issues-processor.ts index 8858b718..b4148876 100644 --- a/src/classes/issues-processor.ts +++ b/src/classes/issues-processor.ts @@ -104,12 +104,12 @@ export class IssuesProcessor { } async processIssues(page: Readonly = 1): Promise { - // get the next batch of issues + // get the next batch of items const issues: Issue[] = await this.getIssues(page); if (issues.length <= 0) { this._logger.info( - LoggerService.green(`No more issues found to process. Exiting...`) + LoggerService.green(`No more items found to process. Exiting...`) ); this.statistics ?.setOperationsCount(this.operations.getConsumedOperationsCount()) @@ -121,11 +121,11 @@ export class IssuesProcessor { } else { this._logger.info( `${LoggerService.yellow( - 'Processing the batch of issues ' + 'Processing the batch of items ' )} ${LoggerService.cyan(`#${page}`)} ${LoggerService.yellow( ' containing ' )} ${LoggerService.cyan(issues.length)} ${LoggerService.yellow( - ` issue${issues.length > 1 ? 's' : ''}...` + ` item${issues.length > 1 ? 's' : ''}...` )}` ); } @@ -171,7 +171,7 @@ export class IssuesProcessor { ); this._logger.warning( `${LoggerService.yellowBright( - 'If you think that not enough issues were processed you could try to increase the quantity related to the ' + 'If you think that not enough items were processed you could try to increase the quantity related to the ' )} ${this._logger.createOptionLink( Option.OperationsPerRun )} ${LoggerService.yellowBright( @@ -555,7 +555,7 @@ export class IssuesProcessor { }); return comments.data; } catch (error) { - this._logger.error(`List issue comments error: ${error.message}`); + this._logger.error(`List $$type comments error: ${error.message}`); return Promise.resolve([]); } } @@ -579,7 +579,7 @@ export class IssuesProcessor { new Issue(this.options, issue as Readonly) ); } catch (error) { - throw Error(`Getting issues was blocked by the error: ${error.message}`); + throw Error(`Getting items was blocked by the error: ${error.message}`); } }