feat: remove the exempt-all-milestones option

BREAKING CHANGE:
The option exempt-all-milestones was removed

README.md

@@ -29,7 +29,7 @@ You can find more information about the required permissions under the correspon
 Every argument is optional.
 
 | Input                                                               | Description                                                             | Default               |
-| ------------------------------------------------------------------- | ------------------------------------------------------------------------ | --------------------- |
+| ------------------------------------------------------------------- | ----------------------------------------------------------------------- | --------------------- | ------- |
 | [repo-token](#repo-token)                                           | PAT for GitHub API authentication                                       | `${{ github.token }}` |
 | [days-before-stale](#days-before-stale)                             | Idle number of days before marking issues/PRs stale                     | `60`                  |
 | [days-before-issue-stale](#days-before-issue-stale)                 | Override [days-before-stale](#days-before-stale) for issues only        |                       |
@@ -66,9 +66,8 @@ Every argument is optional.
 | [exempt-milestones](#exempt-milestones)                             | Milestones on issues/PRs exempted from stale                            |                       |
 | [exempt-issue-milestones](#exempt-issue-milestones)                 | Override [exempt-milestones](#exempt-milestones) for issues only        |                       |
 | [exempt-pr-milestones](#exempt-pr-milestones)                       | Override [exempt-milestones](#exempt-milestones) for PRs only           |                       |
-| [exempt-all-milestones](#exempt-all-milestones)                     | Exempt all issues/PRs with milestones from stale                         | `false`               |
+| [exempt-all-issue-milestones](#exempt-all-issue-milestones)         | Exempt all issues with milestones from stale                            |                       | `false` |
-| [exempt-all-issue-milestones](#exempt-all-issue-milestones)         | Override [exempt-all-milestones](#exempt-all-milestones) for issues only |                       |
+| [exempt-all-pr-milestones](#exempt-all-pr-milestones)               | Exempt all PRs with milestones from stale                               |                       | `false` |
-| [exempt-all-pr-milestones](#exempt-all-pr-milestones)               | Override [exempt-all-milestones](#exempt-all-milestones) for PRs only    |                       |
 | [exempt-issue-assignees](#exempt-issue-assignees)                   | Assignees on issues exempted from stale                                 |                       |
 | [exempt-pr-assignees](#exempt-pr-assignees)                         | Assignees on PRs exempted from stale                                    |                       |
 | [exempt-all-issue-assignees](#exempt-all-issue-assignees)           | Exempt all issues with assignees from stale                             | `false`               |
@@ -122,7 +121,8 @@ You can fine tune which issues or pull requests should be marked as stale based
 - [any-of-labels](#any-of-labels)
 - [start-date](#start-date)
 - [exempt-milestones](#exempt-milestones)
-- [exempt-all-milestones](#exempt-all-milestones)
+- [exempt-all-issue-milestones](#exempt-all-issue-milestones)
+- [exempt-all-pr-milestones](#exempt-all-pr-milestones)
 - [exempt-issue-assignees](#exempt-issue-assignees)
 - [exempt-pr-assignees](#exempt-pr-assignees)
 - [exempt-all-issue-assignees](#exempt-all-issue-assignees)
@@ -412,25 +412,21 @@ Override [exempt-milestones](#exempt-milestones) but only to process the pull re
 
 Default value: unset
 
-#### exempt-all-milestones
+#### exempt-all-issue-milestones
 
-If set to `true`, the issues or the pull requests with a milestone will not be marked as stale automatically.
+If set to `true`, the issues with a milestone will not be marked as stale automatically.
 
 Priority over [exempt-milestones](#exempt-milestones).
 
 Default value: `false`
 
-#### exempt-all-issue-milestones
-
-Override [exempt-all-milestones](#exempt-all-milestones) but only to exempt the issues with a milestone to be marked as stale automatically.
-
-Default value: unset
-
 #### exempt-all-pr-milestones
 
-Override [exempt-all-milestones](#exempt-all-milestones) but only to exempt the pull requests with a milestone to be marked as stale automatically.
+If set to `true`, the pull requests with a milestone will not be marked as stale automatically.
 
-Default value: unset
+Priority over [exempt-milestones](#exempt-milestones).
+
+Default value: `false`
 
 #### exempt-issue-assignees
 

__tests__/constants/default-processor-options.ts

@@ -35,9 +35,8 @@ export const DefaultProcessorOptions: IIssuesProcessorOptions = Object.freeze({
   exemptMilestones: '',
   exemptIssueMilestones: '',
   exemptPrMilestones: '',
-  exemptAllMilestones: false,
+  exemptAllIssueMilestones: false,
-  exemptAllIssueMilestones: undefined,
+  exemptAllPrMilestones: false,
-  exemptAllPrMilestones: undefined,
   exemptAssignees: '',
   exemptIssueAssignees: '',
   exemptPrAssignees: '',

action.yml

@@ -72,17 +72,13 @@ inputs:
     description: 'The milestones that mean a pull request is exempt from being marked as stale. Separate multiple milestones with commas (eg. "milestone1,milestone2"). Override "exempt-milestones" option regarding only the pull requests.'
     default: ''
     required: false
-  exempt-all-milestones:
+  exempt-all-issue-milestones:
-    description: 'Exempt all issues and pull requests with milestones from being marked as stale. Default to false.'
+    description: 'Exempt all issues with milestones from being marked as stale. Default to false.'
     default: 'false'
     required: false
-  exempt-all-issue-milestones:
-    description: 'Exempt all issues with milestones from being marked as stale. Override "exempt-all-milestones" option regarding only the issues.'
-    default: ''
-    required: false
   exempt-all-pr-milestones:
-    description: 'Exempt all pull requests with milestones from being marked as stale. Override "exempt-all-milestones" option regarding only the pull requests.'
+    description: 'Exempt all pull requests with milestones from being marked as stale. Default to false.'
-    default: ''
+    default: 'false'
     required: false
   only-labels:
     description: 'Only issues or pull requests with all of these labels are checked if stale. Defaults to `` (disabled) and can be a comma-separated list of labels.'

dist/index.js

@@ -1315,37 +1315,21 @@ class Milestones {
         return false;
     }
     _shouldExemptAllIssueMilestones() {
-        if (this._options.exemptAllIssueMilestones === true) {
+        if (this._options.exemptAllIssueMilestones) {
             this._issueLogger.info(`The option ${this._issueLogger.createOptionLink(option_1.Option.ExemptAllIssueMilestones)} is enabled. Any milestone on this $$type will skip the stale process`);
             return true;
         }
-        else if (this._options.exemptAllIssueMilestones === false) {
         this._issueLogger.info(`The option ${this._issueLogger.createOptionLink(option_1.Option.ExemptAllIssueMilestones)} is disabled. Only some specific milestones on this $$type will skip the stale process`);
         return false;
     }
-        this._logExemptAllMilestonesOption();
-        return this._options.exemptAllMilestones;
-    }
     _shouldExemptAllPullRequestMilestones() {
-        if (this._options.exemptAllPrMilestones === true) {
+        if (this._options.exemptAllPrMilestones) {
             this._issueLogger.info(`The option ${this._issueLogger.createOptionLink(option_1.Option.ExemptAllPrMilestones)} is enabled. Any milestone on this $$type will skip the stale process`);
             return true;
         }
-        else if (this._options.exemptAllPrMilestones === false) {
         this._issueLogger.info(`The option ${this._issueLogger.createOptionLink(option_1.Option.ExemptAllPrMilestones)} is disabled. Only some specific milestones on this $$type will skip the stale process`);
         return false;
     }
-        this._logExemptAllMilestonesOption();
-        return this._options.exemptAllMilestones;
-    }
-    _logExemptAllMilestonesOption() {
-        if (this._options.exemptAllMilestones) {
-            this._issueLogger.info(`The option ${this._issueLogger.createOptionLink(option_1.Option.ExemptAllMilestones)} is enabled. Any milestone on this $$type will skip the stale process`);
-        }
-        else {
-            this._issueLogger.info(`The option ${this._issueLogger.createOptionLink(option_1.Option.ExemptAllMilestones)} is disabled. Only some specific milestones on this $$type will skip the stale process`);
-        }
-    }
     _logSkip() {
         this._issueLogger.info(logger_service_1.LoggerService.white('└──'), 'Skip the milestones checks');
     }
@@ -1814,7 +1798,6 @@ var Option;
     Option["ExemptMilestones"] = "exempt-milestones";
     Option["ExemptIssueMilestones"] = "exempt-issue-milestones";
     Option["ExemptPrMilestones"] = "exempt-pr-milestones";
-    Option["ExemptAllMilestones"] = "exempt-all-milestones";
     Option["ExemptAllIssueMilestones"] = "exempt-all-issue-milestones";
     Option["ExemptAllPrMilestones"] = "exempt-all-pr-milestones";
     Option["ExemptIssueAssignees"] = "exempt-issue-assignees";
@@ -2122,9 +2105,8 @@ function _getAndValidateArgs() {
         exemptMilestones: core.getInput('exempt-milestones'),
         exemptIssueMilestones: core.getInput('exempt-issue-milestones'),
         exemptPrMilestones: core.getInput('exempt-pr-milestones'),
-        exemptAllMilestones: core.getInput('exempt-all-milestones') === 'true',
+        exemptAllIssueMilestones: core.getInput('exempt-all-issue-milestones') === 'true',
-        exemptAllIssueMilestones: _toOptionalBoolean('exempt-all-issue-milestones'),
+        exemptAllPrMilestones: core.getInput('exempt-all-pr-milestones') === 'true',
-        exemptAllPrMilestones: _toOptionalBoolean('exempt-all-pr-milestones'),
         exemptIssueAssignees: core.getInput('exempt-issue-assignees'),
         exemptPrAssignees: core.getInput('exempt-pr-assignees'),
         exemptAllIssueAssignees: core.getInput('exempt-all-issue-assignees') === 'true',

src/classes/issue.spec.ts

@@ -46,9 +46,8 @@ describe('Issue', (): void => {
       exemptMilestones: '',
       exemptIssueMilestones: '',
       exemptPrMilestones: '',
-      exemptAllMilestones: false,
+      exemptAllIssueMilestones: false,
-      exemptAllIssueMilestones: undefined,
+      exemptAllPrMilestones: false,
-      exemptAllPrMilestones: undefined,
       exemptIssueAssignees: '',
       exemptPrAssignees: '',
       exemptAllIssueAssignees: false,

src/classes/milestones.spec.ts

@@ -12,7 +12,11 @@ describe('Milestones', (): void => {
   let issueInterface: IIssue;
 
   beforeEach((): void => {
-    optionsInterface = {...DefaultProcessorOptions, exemptAllMilestones: false};
+    optionsInterface = {
+      ...DefaultProcessorOptions,
+      exemptAllIssueAssignees: false,
+      exemptAllPrMilestones: false
+    };
     issueInterface = generateIIssue();
   });
 
@@ -286,45 +290,6 @@ describe('Milestones', (): void => {
         });
       });
 
-      describe('when the given options are configured to exempt all milestones', (): void => {
-        beforeEach((): void => {
-          optionsInterface.exemptAllMilestones = true;
-        });
-
-        describe('when the given issue does not have a milestone', (): void => {
-          beforeEach((): void => {
-            issueInterface.milestone = undefined;
-          });
-
-          it('should return false', (): void => {
-            expect.assertions(1);
-            issue = new Issue(optionsInterface, issueInterface);
-            milestones = new Milestones(optionsInterface, issue);
-
-            const result = milestones.shouldExemptMilestones();
-
-            expect(result).toStrictEqual(false);
-          });
-        });
-
-        describe('when the given issue does have a milestone', (): void => {
-          beforeEach((): void => {
-            issueInterface.milestone = {
-              title: 'dummy-exempt-issue-milestone'
-            };
-          });
-
-          it('should return true', (): void => {
-            expect.assertions(1);
-            issue = new Issue(optionsInterface, issueInterface);
-            milestones = new Milestones(optionsInterface, issue);
-
-            const result = milestones.shouldExemptMilestones();
-
-            expect(result).toStrictEqual(true);
-          });
-        });
-
       describe('when the given options are not configured to exempt all issue milestones', (): void => {
         beforeEach((): void => {
           optionsInterface.exemptAllIssueMilestones = false;
@@ -405,7 +370,6 @@ describe('Milestones', (): void => {
         });
       });
     });
-    });
 
     describe('when the given issue is a pull request', (): void => {
       beforeEach((): void => {
@@ -674,45 +638,6 @@ describe('Milestones', (): void => {
         });
       });
 
-      describe('when the given options are configured to exempt all milestones', (): void => {
-        beforeEach((): void => {
-          optionsInterface.exemptAllMilestones = true;
-        });
-
-        describe('when the given pull request does not have a milestone', (): void => {
-          beforeEach((): void => {
-            issueInterface.milestone = undefined;
-          });
-
-          it('should return false', (): void => {
-            expect.assertions(1);
-            issue = new Issue(optionsInterface, issueInterface);
-            milestones = new Milestones(optionsInterface, issue);
-
-            const result = milestones.shouldExemptMilestones();
-
-            expect(result).toStrictEqual(false);
-          });
-        });
-
-        describe('when the given pull request does have a milestone', (): void => {
-          beforeEach((): void => {
-            issueInterface.milestone = {
-              title: 'dummy-exempt-pr-milestone'
-            };
-          });
-
-          it('should return true', (): void => {
-            expect.assertions(1);
-            issue = new Issue(optionsInterface, issueInterface);
-            milestones = new Milestones(optionsInterface, issue);
-
-            const result = milestones.shouldExemptMilestones();
-
-            expect(result).toStrictEqual(true);
-          });
-        });
-
       describe('when the given options are not configured to exempt all pull request milestones', (): void => {
         beforeEach((): void => {
           optionsInterface.exemptAllPrMilestones = false;
@@ -794,5 +719,4 @@ describe('Milestones', (): void => {
       });
     });
   });
-  });
 });

src/classes/milestones.ts

@@ -225,7 +225,7 @@ export class Milestones {
   }
 
   private _shouldExemptAllIssueMilestones(): boolean {
-    if (this._options.exemptAllIssueMilestones === true) {
+    if (this._options.exemptAllIssueMilestones) {
       this._issueLogger.info(
         `The option ${this._issueLogger.createOptionLink(
           Option.ExemptAllIssueMilestones
@@ -233,7 +233,8 @@ export class Milestones {
       );
 
       return true;
-    } else if (this._options.exemptAllIssueMilestones === false) {
+    }
+
     this._issueLogger.info(
       `The option ${this._issueLogger.createOptionLink(
         Option.ExemptAllIssueMilestones
@@ -243,13 +244,8 @@ export class Milestones {
     return false;
   }
 
-    this._logExemptAllMilestonesOption();
-
-    return this._options.exemptAllMilestones;
-  }
-
   private _shouldExemptAllPullRequestMilestones(): boolean {
-    if (this._options.exemptAllPrMilestones === true) {
+    if (this._options.exemptAllPrMilestones) {
       this._issueLogger.info(
         `The option ${this._issueLogger.createOptionLink(
           Option.ExemptAllPrMilestones
@@ -257,7 +253,8 @@ export class Milestones {
       );
 
       return true;
-    } else if (this._options.exemptAllPrMilestones === false) {
+    }
+
     this._issueLogger.info(
       `The option ${this._issueLogger.createOptionLink(
         Option.ExemptAllPrMilestones
@@ -267,27 +264,6 @@ export class Milestones {
     return false;
   }
 
-    this._logExemptAllMilestonesOption();
-
-    return this._options.exemptAllMilestones;
-  }
-
-  private _logExemptAllMilestonesOption(): void {
-    if (this._options.exemptAllMilestones) {
-      this._issueLogger.info(
-        `The option ${this._issueLogger.createOptionLink(
-          Option.ExemptAllMilestones
-        )} is enabled. Any milestone on this $$type will skip the stale process`
-      );
-    } else {
-      this._issueLogger.info(
-        `The option ${this._issueLogger.createOptionLink(
-          Option.ExemptAllMilestones
-        )} is disabled. Only some specific milestones on this $$type will skip the stale process`
-      );
-    }
-  }
-
   private _logSkip(): void {
     this._issueLogger.info(
       LoggerService.white('└──'),

src/enums/option.ts

@@ -31,7 +31,6 @@ export enum Option {
   ExemptMilestones = 'exempt-milestones',
   ExemptIssueMilestones = 'exempt-issue-milestones',
   ExemptPrMilestones = 'exempt-pr-milestones',
-  ExemptAllMilestones = 'exempt-all-milestones',
   ExemptAllIssueMilestones = 'exempt-all-issue-milestones',
   ExemptAllPrMilestones = 'exempt-all-pr-milestones',
   ExemptIssueAssignees = 'exempt-issue-assignees',

src/interfaces/issues-processor-options.ts

@@ -35,9 +35,8 @@ export interface IIssuesProcessorOptions {
   exemptMilestones: string;
   exemptIssueMilestones: string;
   exemptPrMilestones: string;
-  exemptAllMilestones: boolean;
+  exemptAllIssueMilestones: boolean;
-  exemptAllIssueMilestones: boolean | undefined;
+  exemptAllPrMilestones: boolean;
-  exemptAllPrMilestones: boolean | undefined;
   exemptIssueAssignees: string;
   exemptPrAssignees: string;
   exemptAllIssueAssignees: boolean;

src/main.ts

@@ -72,9 +72,9 @@ function _getAndValidateArgs(): IIssuesProcessorOptions {
     exemptMilestones: core.getInput('exempt-milestones'),
     exemptIssueMilestones: core.getInput('exempt-issue-milestones'),
     exemptPrMilestones: core.getInput('exempt-pr-milestones'),
-    exemptAllMilestones: core.getInput('exempt-all-milestones') === 'true',
+    exemptAllIssueMilestones:
-    exemptAllIssueMilestones: _toOptionalBoolean('exempt-all-issue-milestones'),
+      core.getInput('exempt-all-issue-milestones') === 'true',
-    exemptAllPrMilestones: _toOptionalBoolean('exempt-all-pr-milestones'),
+    exemptAllPrMilestones: core.getInput('exempt-all-pr-milestones') === 'true',
     exemptIssueAssignees: core.getInput('exempt-issue-assignees'),
     exemptPrAssignees: core.getInput('exempt-pr-assignees'),
     exemptAllIssueAssignees: