Add API failure handling/logging

This commit is contained in:
Ross Brodbeck 2020-06-08 07:41:31 -04:00
parent c72e3d7ff2
commit 65bccdf399
2 changed files with 145 additions and 82 deletions

117
dist/index.js vendored
View File

@ -8755,27 +8755,39 @@ class IssueProcessor {
listIssueComments(issueNumber, sinceDate) { listIssueComments(issueNumber, sinceDate) {
return __awaiter(this, void 0, void 0, function* () { return __awaiter(this, void 0, void 0, function* () {
// find any comments since date on the given issue // find any comments since date on the given issue
const comments = yield this.client.issues.listComments({ try {
owner: github.context.repo.owner, const comments = yield this.client.issues.listComments({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issueNumber, repo: github.context.repo.repo,
since: sinceDate issue_number: issueNumber,
}); since: sinceDate
return comments.data; });
return comments.data;
}
catch (error) {
core.error(`List issue comments error: ${error.message}`);
return Promise.resolve([]);
}
}); });
} }
// grab issues from github in baches of 100 // grab issues from github in baches of 100
getIssues(page) { getIssues(page) {
return __awaiter(this, void 0, void 0, function* () { return __awaiter(this, void 0, void 0, function* () {
const issueResult = yield this.client.issues.listForRepo({ try {
owner: github.context.repo.owner, const issueResult = yield this.client.issues.listForRepo({
repo: github.context.repo.repo, owner: github.context.repo.owner,
state: 'open', repo: github.context.repo.repo,
labels: this.options.onlyLabels, state: 'open',
per_page: 100, labels: this.options.onlyLabels,
page per_page: 100,
}); page
return issueResult.data; });
return issueResult.data;
}
catch (error) {
core.error(`Get issues for repo error: ${error.message}`);
return Promise.resolve([]);
}
}); });
} }
// Mark an issue as stale with a comment and a label // Mark an issue as stale with a comment and a label
@ -8788,21 +8800,36 @@ class IssueProcessor {
// so that close calculations work correctly // so that close calculations work correctly
const newUpdatedAtDate = new Date(); const newUpdatedAtDate = new Date();
issue.updated_at = newUpdatedAtDate.toString(); issue.updated_at = newUpdatedAtDate.toString();
// of days to wait before actually closing the issue.
const daysBeforeStaleInMillis = 1000 * 60 * 60 * 24 * this.options.daysBeforeStale;
const newUpdatedAtDate = new Date();
newUpdatedAtDate.setTime(newUpdatedAtDate.getTime() - daysBeforeStaleInMillis);
issue.updated_at = newUpdatedAtDate.toString();
if (this.options.debugOnly) { if (this.options.debugOnly) {
return; return;
} }
yield this.client.issues.createComment({ try {
owner: github.context.repo.owner, yield this.client.issues.createComment({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
body: staleMessage issue_number: issue.number,
}); body: staleMessage
yield this.client.issues.addLabels({ });
owner: github.context.repo.owner, }
repo: github.context.repo.repo, catch (error) {
issue_number: issue.number, core.error(`Error creating a comment: ${error.message}`);
labels: [staleLabel] }
}); try {
yield this.client.issues.addLabels({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
issue_number: issue.number,
labels: [staleLabel]
});
}
catch (error) {
core.error(`Error adding a label: ${error.message}`);
}
}); });
} }
// Close an issue based on staleness // Close an issue based on staleness
@ -8814,12 +8841,17 @@ class IssueProcessor {
if (this.options.debugOnly) { if (this.options.debugOnly) {
return; return;
} }
yield this.client.issues.update({ try {
owner: github.context.repo.owner, yield this.client.issues.update({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
state: 'closed' issue_number: issue.number,
}); state: 'closed'
});
}
catch (error) {
core.error(`Error updating an issue: ${error.message}`);
}
}); });
} }
// Remove a label from an issue // Remove a label from an issue
@ -8831,12 +8863,17 @@ class IssueProcessor {
if (this.options.debugOnly) { if (this.options.debugOnly) {
return; return;
} }
yield this.client.issues.removeLabel({ try {
owner: github.context.repo.owner, yield this.client.issues.removeLabel({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
name: encodeURIComponent(label) // A label can have a "?" in the name issue_number: issue.number,
}); name: encodeURIComponent(label) // A label can have a "?" in the name
});
}
catch (error) {
core.error(`Error removing a label: ${error.message}`);
}
}); });
} }
// returns the creation date of a given label on an issue (or nothing if no label existed) // returns the creation date of a given label on an issue (or nothing if no label existed)

View File

@ -268,28 +268,38 @@ export class IssueProcessor {
sinceDate: string sinceDate: string
): Promise<Comment[]> { ): Promise<Comment[]> {
// find any comments since date on the given issue // find any comments since date on the given issue
const comments = await this.client.issues.listComments({ try {
owner: github.context.repo.owner, const comments = await this.client.issues.listComments({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issueNumber, repo: github.context.repo.repo,
since: sinceDate issue_number: issueNumber,
}); since: sinceDate
});
return comments.data; return comments.data;
} catch (error) {
core.error(`List issue comments error: ${error.message}`);
return Promise.resolve([]);
}
} }
// grab issues from github in baches of 100 // grab issues from github in baches of 100
private async getIssues(page: number): Promise<Issue[]> { private async getIssues(page: number): Promise<Issue[]> {
const issueResult: OctoKitIssueList = await this.client.issues.listForRepo({ try {
owner: github.context.repo.owner, const issueResult: OctoKitIssueList = await this.client.issues.listForRepo(
repo: github.context.repo.repo, {
state: 'open', owner: github.context.repo.owner,
labels: this.options.onlyLabels, repo: github.context.repo.repo,
per_page: 100, state: 'open',
page labels: this.options.onlyLabels,
}); per_page: 100,
page
return issueResult.data; }
);
return issueResult.data;
} catch (error) {
core.error(`Get issues for repo error: ${error.message}`);
return Promise.resolve([]);
}
} }
// Mark an issue as stale with a comment and a label // Mark an issue as stale with a comment and a label
@ -313,19 +323,27 @@ export class IssueProcessor {
return; return;
} }
await this.client.issues.createComment({ try {
owner: github.context.repo.owner, await this.client.issues.createComment({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
body: staleMessage issue_number: issue.number,
}); body: staleMessage
});
} catch (error) {
core.error(`Error creating a comment: ${error.message}`);
}
await this.client.issues.addLabels({ try {
owner: github.context.repo.owner, await this.client.issues.addLabels({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
labels: [staleLabel] issue_number: issue.number,
}); labels: [staleLabel]
});
} catch (error) {
core.error(`Error adding a label: ${error.message}`);
}
} }
// Close an issue based on staleness // Close an issue based on staleness
@ -342,12 +360,16 @@ export class IssueProcessor {
return; return;
} }
await this.client.issues.update({ try {
owner: github.context.repo.owner, await this.client.issues.update({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
state: 'closed' issue_number: issue.number,
}); state: 'closed'
});
} catch (error) {
core.error(`Error updating an issue: ${error.message}`);
}
} }
// Remove a label from an issue // Remove a label from an issue
@ -364,12 +386,16 @@ export class IssueProcessor {
return; return;
} }
await this.client.issues.removeLabel({ try {
owner: github.context.repo.owner, await this.client.issues.removeLabel({
repo: github.context.repo.repo, owner: github.context.repo.owner,
issue_number: issue.number, repo: github.context.repo.repo,
name: encodeURIComponent(label) // A label can have a "?" in the name issue_number: issue.number,
}); name: encodeURIComponent(label) // A label can have a "?" in the name
});
} catch (error) {
core.error(`Error removing a label: ${error.message}`);
}
} }
// returns the creation date of a given label on an issue (or nothing if no label existed) // returns the creation date of a given label on an issue (or nothing if no label existed)