From 1ab84ac8e889714be0ccf3071872ce40f0f729b8 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Fri, 25 Nov 2022 00:54:32 +0800 Subject: [PATCH] Fix duplicated log when register failed --- cmd/register.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd/register.go b/cmd/register.go index fced14b..3f08c61 100644 --- a/cmd/register.go +++ b/cmd/register.go @@ -252,7 +252,7 @@ func registerNoInteractive(envFile string, regArgs *registerArgs) error { } if err := doRegister(&cfg, inputs); err != nil { log.Errorf("Failed to register runner: %v", err) - return err + return nil } log.Infof("Runner registered successfully.") return nil @@ -296,10 +296,5 @@ func doRegister(cfg *config.Config, inputs *registerInputs) error { cfg.Runner.Token = inputs.Token cfg.Runner.Labels = inputs.CustomLabels _, err := register.New(cli).Register(ctx, cfg.Runner) - if err != nil { - log.WithError(err).Errorln("Cannot register the runner") - return nil - } - - return nil + return err }