From d4caa7e0657b40da46db306e3c7a7c3ea74832a2 Mon Sep 17 00:00:00 2001 From: sando38 Date: Tue, 9 May 2023 16:09:48 +0800 Subject: [PATCH] Dockerfile: Improve signal handling by adding a runtime init (#180) This adds tini as a runtime init (https://github.com/krallin/tini). It improves signal handling for the container, see https://github.com/krallin/tini#why-tini. An alternative could be to run the container with `docker run --init ...` which also places tini as a runtime init as PID 1. Co-authored-by: sando38 Reviewed-on: https://gitea.com/gitea/act_runner/pulls/180 Reviewed-by: Jason Song Co-authored-by: sando38 Co-committed-by: sando38 --- Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 30331e4..8205016 100644 --- a/Dockerfile +++ b/Dockerfile @@ -8,10 +8,10 @@ RUN make clean && make build FROM alpine:3.17 RUN apk add --no-cache \ - git=2.38.5-r0 bash=5.2.15-r0 \ + git=2.38.5-r0 bash=5.2.15-r0 tini=0.19.0-r1 \ && rm -rf /var/cache/apk/* COPY --from=builder /opt/src/act_runner/act_runner /usr/local/bin/act_runner COPY run.sh /opt/act/run.sh -ENTRYPOINT ["/opt/act/run.sh"] +ENTRYPOINT ["/sbin/tini","--","/opt/act/run.sh"]