use secrets for s3 info (#530 )

Changelog for v0.9.1 (#535 )
Reviewed-on: https://gitea.com/gitea/tea/pulls/535 Reviewed-by: John Olheiser <john+gitea@jolheiser.com>
2023-02-16 00:11:01 +01:00 · 2023-02-16 06:22:31 +08:00 · 2022-09-29 20:35:57 +08:00
3 changed files with 37 additions and 12 deletions
--- a/.drone.yml
+++ b/.drone.yml
@ -110,11 +110,16 @@ steps:
  pull: always
  image: woodpeckerci/plugin-s3:latest
  settings:
-    acl: public-read
-    bucket: gitea-artifacts
+    acl:
+      from_secret: aws_s3_acl
+    region:
+      from_secret: aws_s3_region
+    bucket:
+      from_secret: aws_s3_bucket
    endpoint:
-      from_secret: aws_endpoint
-    path_style: true
+      from_secret: aws_s3_endpoint
+    path_style:
+      from_secret: aws_s3_path_style
    source: "dist/release/*"
    strip_prefix: dist/release/
    target: "/tea/${DRONE_TAG##v}"
@ -131,10 +136,16 @@ steps:
  pull: always
  image: woodpeckerci/plugin-s3:latest
  settings:
-    acl: public-read
-    bucket: gitea-artifacts
+    acl:
+      from_secret: aws_s3_acl
+    region:
+      from_secret: aws_s3_region
+    bucket:
+      from_secret: aws_s3_bucket
    endpoint:
-      from_secret: aws_endpoint
+      from_secret: aws_s3_endpoint
+    path_style:
+      from_secret: aws_s3_path_style
    source: "dist/release/*"
    strip_prefix: dist/release/
    target: "/tea/${DRONE_BRANCH##release/v}"
@ -153,10 +164,16 @@ steps:
  pull: always
  image: woodpeckerci/plugin-s3:latest
  settings:
-    acl: public-read
-    bucket: gitea-artifacts
+    acl:
+      from_secret: aws_s3_acl
+    region:
+      from_secret: aws_s3_region
+    bucket:
+      from_secret: aws_s3_bucket
    endpoint:
-      from_secret: aws_endpoint
+      from_secret: aws_s3_endpoint
+    path_style:
+      from_secret: aws_s3_path_style
    source: "dist/release/*"
    strip_prefix: dist/release/
    target: /tea/main
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -1,5 +1,10 @@
 # Changelog

+## [v0.9.1](https://gitea.com/gitea/tea/releases/tag/v0.9.1) - 2023-02-15
+
+* BUGFIXES
+  * Print pull dont crash if it has TeamReviewRequests (#517)
+
 ## [v0.9.0](https://gitea.com/gitea/tea/releases/tag/v0.9.0) - 2022-09-13

 * BREAKING
--- a/modules/print/pull.go
+++ b/modules/print/pull.go
@ -99,11 +99,14 @@ func formatReviews(reviews []*gitea.PullReview) string {
 		case gitea.ReviewStateApproved,
 			gitea.ReviewStateRequestChanges,
 			gitea.ReviewStateRequestReview:
+			// only user reviews are supported no team review requests
+			if review.Reviewer != nil {
 				if r, ok := reviewByUser[review.Reviewer.ID]; !ok || review.Submitted.After(r.Submitted) {
 					reviewByUser[review.Reviewer.ID] = review
 				}
 			}
 		}
+	}

 	// group reviews by type
 	usersByState := make(map[gitea.ReviewStateType][]string)
Author	SHA1	Message	Date
techknowlogick	fff1af1029	use secrets for s3 info (#530 )	2023-02-16 00:11:01 +01:00
6543	f28f199e85	Changelog for v0.9.1 (#535 ) Reviewed-on: https://gitea.com/gitea/tea/pulls/535 Reviewed-by: John Olheiser <john+gitea@jolheiser.com>	2023-02-16 06:22:31 +08:00
6543	c00418e74c	Print pull dont crash if it has TeamReviewRequests (#517 ) partial backport of #515 Reviewed-on: https://gitea.com/gitea/tea/pulls/517 Reviewed-by: Norwin <noerw@noreply.gitea.io>	2022-09-29 20:35:57 +08:00