From 0271114e6400fc003d96c8499f0c8e43bbb441f9 Mon Sep 17 00:00:00 2001 From: Denys Konovalov Date: Mon, 16 Oct 2023 23:06:15 +0200 Subject: [PATCH] cleanup repo details icons/labels (#27644) Fix #27596 Change confusing behavior when showing information about a repo via labels and icons. Implement changes proposed by @lng2020 in https://github.com/go-gitea/gitea/pull/27627#pullrequestreview-1678787673. --- options/locale/locale_en-US.ini | 4 +--- templates/admin/repo/list.tmpl | 31 ++++++++++++------------------- templates/explore/repo_list.tmpl | 26 +++++++------------------- templates/repo/header.tmpl | 27 ++++++++++----------------- templates/repo/icon.tmpl | 4 ---- 5 files changed, 30 insertions(+), 62 deletions(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index 867746132210..46138fad5465 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -1030,10 +1030,8 @@ transfer.no_permission_to_reject = You do not have permission to reject this tra desc.private = Private desc.public = Public -desc.private_template = Private template -desc.public_template = Template +desc.template = Template desc.internal = Internal -desc.internal_template = Internal template desc.archived = Archived template.items = Template Items diff --git a/templates/admin/repo/list.tmpl b/templates/admin/repo/list.tmpl index c23b6a1b6301..2581864547b2 100644 --- a/templates/admin/repo/list.tmpl +++ b/templates/admin/repo/list.tmpl @@ -55,29 +55,22 @@ {{.Name}} {{if .IsArchived}} - {{ctx.Locale.Tr "repo.desc.archived"}} + {{ctx.Locale.Tr "repo.desc.archived"}} + {{end}} + {{if .IsPrivate}} + {{ctx.Locale.Tr "repo.desc.private"}} + {{else}} + {{if .Owner.Visibility.IsPrivate}} + {{ctx.Locale.Tr "repo.desc.internal"}} + {{end}} {{end}} {{if .IsTemplate}} - {{if .IsPrivate}} - {{ctx.Locale.Tr "repo.desc.private_template"}} - {{else}} - {{if .Owner.Visibility.IsPrivate}} - {{ctx.Locale.Tr "repo.desc.internal_template"}} - {{end}} - {{end}} - {{else}} - {{if .IsPrivate}} - {{ctx.Locale.Tr "repo.desc.private"}} - {{else}} - {{if .Owner.Visibility.IsPrivate}} - {{ctx.Locale.Tr "repo.desc.internal"}} - {{end}} - {{end}} + {{ctx.Locale.Tr "repo.desc.template"}} {{end}} - {{if .IsFork}} - {{svg "octicon-repo-forked"}} - {{else if .IsMirror}} + {{if .IsMirror}} {{svg "octicon-mirror"}} + {{else if .IsFork}} + {{svg "octicon-repo-forked"}} {{end}} {{.NumWatches}} diff --git a/templates/explore/repo_list.tmpl b/templates/explore/repo_list.tmpl index 35839087433f..1976ed5a1597 100644 --- a/templates/explore/repo_list.tmpl +++ b/templates/explore/repo_list.tmpl @@ -14,29 +14,17 @@ {{if .IsArchived}} {{ctx.Locale.Tr "repo.desc.archived"}} {{end}} - {{if .IsTemplate}} - {{if .IsPrivate}} - {{ctx.Locale.Tr "repo.desc.private_template"}} - {{else}} - {{if .Owner.Visibility.IsPrivate}} - {{ctx.Locale.Tr "repo.desc.internal_template"}} - {{end}} - {{end}} + {{if .IsPrivate}} + {{ctx.Locale.Tr "repo.desc.private"}} {{else}} - {{if .IsPrivate}} - {{ctx.Locale.Tr "repo.desc.private"}} - {{else}} - {{if .Owner.Visibility.IsPrivate}} - {{ctx.Locale.Tr "repo.desc.internal"}} - {{end}} + {{if .Owner.Visibility.IsPrivate}} + {{ctx.Locale.Tr "repo.desc.internal"}} {{end}} {{end}} + {{if .IsTemplate}} + {{ctx.Locale.Tr "repo.desc.template"}} + {{end}} - {{if .IsFork}} - {{svg "octicon-repo-forked"}} - {{else if .IsMirror}} - {{svg "octicon-mirror"}} - {{end}}
{{if .PrimaryLanguage}} diff --git a/templates/repo/header.tmpl b/templates/repo/header.tmpl index 2eb9014cdd6f..895d18d6fd84 100644 --- a/templates/repo/header.tmpl +++ b/templates/repo/header.tmpl @@ -11,26 +11,19 @@
/
{{.Name}}
- {{if .IsTemplate}} - {{if .IsPrivate}} - {{ctx.Locale.Tr "repo.desc.private_template"}} - {{else}} - {{if .Owner.Visibility.IsPrivate}} - {{ctx.Locale.Tr "repo.desc.internal_template"}} - {{end}} - {{end}} - {{else}} - {{if .IsPrivate}} - {{ctx.Locale.Tr "repo.desc.private"}} - {{else}} - {{if .Owner.Visibility.IsPrivate}} - {{ctx.Locale.Tr "repo.desc.internal"}} - {{end}} - {{end}} - {{end}} {{if .IsArchived}} {{ctx.Locale.Tr "repo.desc.archived"}} {{end}} + {{if .IsPrivate}} + {{ctx.Locale.Tr "repo.desc.private"}} + {{else}} + {{if .Owner.Visibility.IsPrivate}} + {{ctx.Locale.Tr "repo.desc.internal"}} + {{end}} + {{end}} + {{if .IsTemplate}} + {{ctx.Locale.Tr "repo.desc.template"}} + {{end}}
{{if $.EnableFeed}} {{svg "octicon-rss" 18}} diff --git a/templates/repo/icon.tmpl b/templates/repo/icon.tmpl index 8ad9a77b1921..5a80b959d00c 100644 --- a/templates/repo/icon.tmpl +++ b/templates/repo/icon.tmpl @@ -1,10 +1,6 @@ {{$avatarLink := (.RelAvatarLink ctx)}} {{if $avatarLink}} {{.FullName}} -{{else if $.IsTemplate}} - {{svg "octicon-repo-template" 32}} -{{else if $.IsPrivate}} - {{svg "octicon-lock" 32}} {{else if $.IsMirror}} {{svg "octicon-mirror" 32}} {{else if $.IsFork}}