From 2a7a03e5b3ca1f24b35003082902e7dda37991bc Mon Sep 17 00:00:00 2001 From: Vyacheslav Bakhmutov Date: Wed, 3 Sep 2014 00:04:22 +0700 Subject: [PATCH] take params for milestone and assignee from query instead of path args --- public/js/app.js | 2 +- routers/repo/issue.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/public/js/app.js b/public/js/app.js index a5bb9569ef0a..2a7cf08bae46 100644 --- a/public/js/app.js +++ b/public/js/app.js @@ -870,7 +870,7 @@ function initIssue() { $.post($m.data("ajax"), { issue: $('#issue').data("id"), - milestone: id + milestoneid: id }, function (json) { if (json.ok) { //window.location.reload(); diff --git a/routers/repo/issue.go b/routers/repo/issue.go index 412d03c6e6a9..59921d551552 100644 --- a/routers/repo/issue.go +++ b/routers/repo/issue.go @@ -582,7 +582,7 @@ func UpdateIssueMilestone(ctx *middleware.Context) { } oldMid := issue.MilestoneId - mid := com.StrTo(ctx.Params(":milestone")).MustInt64() + mid := com.StrTo(ctx.Query("milestoneid")).MustInt64() if oldMid == mid { ctx.JSON(200, map[string]interface{}{ "ok": true, @@ -627,7 +627,7 @@ func UpdateAssignee(ctx *middleware.Context) { return } - aid := com.StrTo(ctx.Params(":assigneeid")).MustInt64() + aid := com.StrTo(ctx.Query("assigneeid")).MustInt64() // Not check for invalid assignne id and give responsibility to owners. issue.AssigneeId = aid if err = models.UpdateIssueUserPairByAssignee(aid, issue.Id); err != nil {