From 48c9865fce915c28fe3759cfb1b75c65feac2f55 Mon Sep 17 00:00:00 2001 From: Jimmy Praet Date: Sat, 28 Nov 2020 12:06:59 +0100 Subject: [PATCH] Fix review request notification issue link when external issue tracker is enabled (#13723) The issue.HTMLURL() automatically gets converted to the expected #issue format by the post processors --- modules/notification/mail/mail.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/notification/mail/mail.go b/modules/notification/mail/mail.go index 9b2c27280f7a..847a2f30a76f 100644 --- a/modules/notification/mail/mail.go +++ b/modules/notification/mail/mail.go @@ -104,7 +104,7 @@ func (m *mailNotifier) NotifyIssueChangeAssignee(doer *models.User, issue *model func (m *mailNotifier) NotifyPullReviewRequest(doer *models.User, issue *models.Issue, reviewer *models.User, isRequest bool, comment *models.Comment) { if isRequest && doer.ID != reviewer.ID && reviewer.EmailNotifications() == models.EmailNotificationsEnabled { - ct := fmt.Sprintf("Requested to review #%d.", issue.Index) + ct := fmt.Sprintf("Requested to review %s.", issue.HTMLURL()) mailer.SendIssueAssignedMail(issue, doer, ct, comment, []string{reviewer.Email}) } }