From a954c93a68072042aa7dad717b6fa002c83a58fb Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Fri, 23 Jun 2023 18:57:01 +0800 Subject: [PATCH] Make buttons in a modal form have proper type. (#25446) Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: silverwind Co-authored-by: Giteabot --- web_src/js/features/common-global.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js index e5fd7c29fce6..8bbf202eff8b 100644 --- a/web_src/js/features/common-global.js +++ b/web_src/js/features/common-global.js @@ -395,6 +395,8 @@ function initGlobalShowModal() { if (colorPickers.length > 0) { initCompColorPicker(); // FIXME: this might cause duplicate init } + // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter" + $modal.find('form button:not(.ok):not([type])').attr('type', 'button'); $modal.modal('setting', { onApprove: () => { // "form-fetch-action" can handle network errors gracefully,