gitea
/
act_runner
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 21 Wiki Activity

Exit with Code 1 if registering a runner fails (#228) 

### It's a "simple dirty fix" and I don't have any experiences with Go, so if this doesn't match your coding compliance, please adjust the code as needed

I'm using bash scripts to register a token

`./act_runner/act_runner register --no-interactive --name runner$number --instance http://localhost:3000 --token $token`

But when a token is invalid, the command still returns 0, which is not practical for automation.
A simple non-zero return would be more convenient for power users and developers.

Co-authored-by: Markus Löffler <markus.loeffler@netcare.de>
Co-authored-by: techknowlogick <techknowlogick@noreply.gitea.com>
Reviewed-on: https://gitea.com/gitea/act_runner/pulls/228
Reviewed-by: techknowlogick <techknowlogick@noreply.gitea.com>
Co-authored-by: MarkusLoeffler01 <markusloeffler01@noreply.gitea.com>
Co-committed-by: MarkusLoeffler01 <markusloeffler01@noreply.gitea.com>
This commit is contained in:
MarkusLoeffler01 2023-06-09 17:34:23 +00:00 committed by techknowlogick
parent a29307a9d9
commit b21d476aca
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/app/cmd/register.go
View File

@ -197,7 +197,7 @@ func registerInteractive(configFile string) error {
if stage == StageWaitingForRegistration { if stage == StageWaitingForRegistration {
log.Infof("Registering runner, name=%s, instance=%s, labels=%v.", inputs.RunnerName, inputs.InstanceAddr, inputs.CustomLabels) log.Infof("Registering runner, name=%s, instance=%s, labels=%v.", inputs.RunnerName, inputs.InstanceAddr, inputs.CustomLabels)
if err := doRegister(cfg, inputs); err != nil { if err := doRegister(cfg, inputs); err != nil {
log.Errorf("Failed to register runner: %v", err) return fmt.Errorf("Failed to register runner: %w", err)
} else { } else {
log.Infof("Runner registered successfully.") log.Infof("Runner registered successfully.")
} }
@ -257,8 +257,7 @@ func registerNoInteractive(configFile string, regArgs *registerArgs) error {
return nil return nil
} }
if err := doRegister(cfg, inputs); err != nil { if err := doRegister(cfg, inputs); err != nil {
log.Errorf("Failed to register runner: %v", err) return fmt.Errorf("Failed to register runner: %w", err)
return nil
} }
log.Infof("Runner registered successfully.") log.Infof("Runner registered successfully.")
return nil return nil