Commit Graph

55 Commits

Author SHA1 Message Date
silverwind 5dabc679aa
Update JS dependencies and add new eslint rules (#30279)
- Run `make update-js`
- Added new eslint rules
- Tested webpack build and swagger ui
2024-04-05 03:35:37 +00:00
silverwind 38d56ca106
Ignore fomantic folder in linters (#30200)
We are not linting these files but editor integrations will still try to
lint, disable that.
2024-03-31 11:41:28 +00:00
Yarden Shoham 34acd8e376
Forbid jQuery `.attr` (#30116)
Use `.getAttribute`, `.setAttribute`, or `.removeAttribute` instead

Signed-off-by: Yarden Shoham <>
2024-03-27 21:49:54 +08:00
silverwind bcb151c220
Enable eslint `space-before-function-paren` (#30078)
Anonymous are set to ignore as I [couldn't
No current violations.

Rule docs:
2024-03-25 23:14:17 +00:00
silverwind 0a2f973de9
Forbid jQuery `is` and fix issues (#30016)
Tested all functionality.


Co-authored-by: Yarden Shoham <>
2024-03-24 17:56:02 +00:00
silverwind 3d751b6ec1
Enforce trailing comma in JS on multiline (#30002)
To keep blame info accurate and to avoid [changes like
it's good to always have a trailing comma, so let's enforce it in JS.

This rule is completely automatically fixable with `make lint-js-fix`
and that's what I did here.
2024-03-22 14:06:53 +00:00
silverwind fa100618c4
Forbid jQuery `.css` and refactor all usage (#29852)
Tested all functionality. There is a [pre-existing
bug]( when moving a
project panels which is not caused by this refactoring.


Co-authored-by: wxiaoguang <>
2024-03-19 16:28:46 +00:00
silverwind 095fdd691d
move some scripts from 'build' to 'tools' directory, misc refactors (#29844)
- Move some scripts from `build` to new `tools` dir. Eventually i would
like to move all but let's do it step-by-step.
- Add dir to eslint and move the files into vars.
- Update docs accordingly.
- While updating docs I noticed we were incorrectly having `public/img`
path still in a few places. Replace those with the current


Co-authored-by: Nanguan Lin <>
Co-authored-by: Giteabot <>
2024-03-17 23:12:36 +01:00
silverwind 21fe512aac
Forbid jQuery `.prop` and fix related issues (#29832)
The issue checkbox code received a few more cleanups and I specifically
tested it. The other changes are trivial. Also, I checked the cases for
how many elements match the jQuery selection to determine querySelector
vs. querySelectorAll.


Co-authored-by: Giteabot <>
2024-03-16 15:08:10 +00:00
Yarden Shoham f9b4efd42c
Forbid HTML injection using jQuery (#29843)

Tested the following components and they work as before:
- notification table
- issue author dropdown
- comment edit box attachments div

Signed-off-by: Yarden Shoham <>
Co-authored-by: Giteabot <>
2024-03-16 13:25:27 +00:00
Yarden Shoham 3cd64949ae
Forbid variables containing jQuery collections not having the `$` prefix (#29839)


Signed-off-by: Yarden Shoham <>
Co-authored-by: silverwind <>
2024-03-16 12:22:16 +00:00
Yarden Shoham 6ead30dbc4
Forbid jQuery AJAX (#29818)
Please use the fetch wrapper instead, or even better `htmx`.

Signed-off-by: Yarden Shoham <>
Co-authored-by: 6543 <>
2024-03-16 02:01:25 +00:00
silverwind a5c570c1e0
Remove jQuery .map() and enable eslint rules for it (#29272)
- Use case in `repo-commit` was tested until the point where the POST
request was sent with the same payload.
- Use case in `repo-legacy` was tested completely with comment editing.
- `jquery/no-fade` was disabled as well to stay in sync with
`no-jquery/no-fade`, had no violations.
2024-02-21 00:05:17 +00:00
silverwind 26b17537e6
Add `eslint-plugin-github` and fix issues (#29201)
This plugin has a few useful rules. The only thing I dislike about it is
that it pulls in a rather big number of dependencies for react-related
rules we don't use, but it can't really be avoided.

Rule docs:
2024-02-16 21:41:23 +00:00
silverwind 4fe37124e9
Update JS and PY dependencies (#29127)
- Update all excluding `@mcaptcha/vanilla-glue` and
- Remove deprecated and duplicate eslint rule
- Tested Monaco, Mermaid and Swagger
2024-02-11 12:55:11 +00:00
silverwind b6bf8041d8
Fix gitea-origin-url with default ports (#29085)
When setting `` on a URL object with no port specified (like is
the case of default port), the resulting URL's port will not change.
Workaround this quirk in the URL standard by explicitely setting port
for the http and https protocols.

Extracted the logic to a function for the purpose of testing. Initially
I wanted to have the function in utils.js, but it turns out esbuild can
not treeshake the unused functions which would result in the
webcomponents chunk having all 2kB utils.js inlined, so it seemed not

2024-02-08 02:37:09 +00:00
silverwind a062725758
Update JS and PY dependencies, build for `es2020` browsers (#28977)
- Update all JS dependencies minus @mcaptcha/vanilla-glue
- Fix new lint errors
- Regenerate SVGs
- Switch to maintained stylelint stylistic plugin
- Tested Mermaid, Citation, Swagger, sorting
- Raise ESBuild target to `es2020` as dictated by `pretty-ms`
2024-02-02 09:36:32 +00:00
silverwind 06dcb251f3
Update JS and PY dependencies (#28120)
- Update all JS and PY dependencies minus `@mcaptcha/vanilla-glue`
- Adapt to eslint rule rename
- Regenerate all SVGs because of [new
optimizations]( from
- Tested mentions, mermaid, vue, api docs
2023-11-20 01:02:57 +01:00
silverwind abd79ddebf
Update JS dependencies (#27922)
- Update all JS dependencies minus @mcaptcha/vanilla-glue (unsolved
error, see
- Migrate deprecated eslint rules to `@stylistic/eslint-plugin-js`
- Enable and autofix `@stylistic/js/no-multiple-empty-lines`
- Regenerate poetry.lock with latest poetry
- Tested Mermaid, Swagger, Citation, Vue
2023-11-06 21:14:32 +00:00
silverwind bd58266957
Update and add new eslint plugins (#27698)
- Switch `eslint-plugin-import` to
[`eslint-plugin-i`](, a fork
with better dependencies
- Update `eslint-plugin-regexp` to 2.0.0 and add new rules
- Add
2023-10-19 21:51:56 +02:00
silverwind 0bccf078c9
Update JS and PY dependencies (#27501)
- Update all JS and PY dependencies
- Enable eslint `prefer-object-has-own` and autofix issue
- Fix styling on citation buttons
- Tested citation, mermaid, monaco, swagger, katex

Citation button issue was that these buttons were not filled:

<img width="136" alt="Screenshot 2023-10-07 at 14 05 08"

Co-authored-by: techknowlogick <>
2023-10-08 00:16:20 +00:00
silverwind ee27b94b2c
Use vitest globals (#27102)
Enable [globals]( in vitest, reducing
the noise in test files.
2023-09-27 04:37:13 +00:00
silverwind a101dbaa79
Update JS and Poetry dependencies and eslint (#27200)
- Update all JS and Poetry dependencies
- Remove deprecated `eslint-plugin-custom-elements` and replace it with
rules from `eslint-plugin-wc`
- Add a convenience `make update` to update both js and py dependencies
- Tested markdown toolbar, swagger and citation
2023-09-22 22:51:48 +02:00
silverwind ae8e8f055e
Use fetch helpers instead of fetch (#27026)
WIP because:

- [x] Some calls set a `content-type` but send no body, can likely
remove the header
- [x] Need to check whether `charset=utf-8` has any significance on the
webauthn calls, I assume not as it is the default for json content.
- [x] Maybe `no-restricted-globals` is better for eslint, but will
require a lot of duplication in the yaml or moving eslint config to a
`.js` extension.
- [x] Maybe export `request` as `fetch`, shadowing the global.
2023-09-19 00:50:30 +00:00
silverwind 3c0c279658
Add `yamllint` (#26965)
So that does not happen
again. Merge this after that PR. Config is based on


Co-authored-by: techknowlogick <>
2023-09-07 22:24:06 -04:00
silverwind 8e644d3460
Update js and py dependencies (#26243)
- Update all JS and PY dependencies minus
`eslint-plugin-eslint-comments` (because of
- Regenerate SVGs
- Remove depreacted eslint rule
- Tested mermaid and swagger
2023-07-31 01:16:12 +02:00
silverwind 2b6f224336
Update JS dependencies (#26025)
- Update all JS dependencies
- Tweak eslint config, disable SequenceExpression aka. [Comma
remove deprecated rule
- Add new stylelint rule
- Tested Monaco and Swagger
2023-07-21 11:34:10 +08:00
silverwind 429c12fe62
Update JS dependencies, misc tweaks (#25768)
- Update all JS dependencies minus stylelint because of
- Misc tweaks to eslint and stylelint configs
- Tested Monaco and Mermaid
2023-07-08 12:26:35 +02:00
silverwind c71e8abbc3
Add toasts to UI (#25449)

In some case like async success/error, it is useful to show toasts in UI.
2023-06-27 02:45:24 +00:00
silverwind 263ed09bbf
Update js dependencies (#25137)
- Update all JS dependencies
- Tweak eslint for more generic globs
- Tested mermaid, pdf, monaco

Co-authored-by: Giteabot <>
2023-06-08 10:54:31 +00:00
silverwind 4aacc3ac78
Add two eslint plugins (#24776)
Add these two plugins and autofix issues:

2023-05-18 09:14:31 +08:00
silverwind 31ad6181e1
Switch to `@eslint-community/eslint-comments` (#24736)
is unmaintained, switch to the community fork.

for discussion.
2023-05-15 17:29:23 +00:00
silverwind f745016092
Add `eslint-plugin-eslint-comments` (#24690)
which prevents some abuse related to eslint comments.
2023-05-12 20:38:17 +00:00
silverwind a4d6f83b5b
Add `eslint-plugin-wc` (#24689)
Add [eslint-plugin-wc](,
another small set of eslint rules covering web components.
2023-05-12 19:15:49 +00:00
silverwind d5b2bf9044
Update JS dependencies, add new eslint rules (#24597)
- Update all JS dependencies
- Enable new eslint rules, fix issue (some via autofix)
- Fix some missed eslint rule renames from [unicorn
- Tested Monaco, Katex, Swagger UI


Co-authored-by: 6543 <>
Co-authored-by: Giteabot <>
2023-05-09 02:35:49 +00:00
silverwind 50133b02bd
Add eslint-plugin-regexp (#24361)
and fix discovered issues. Config is mostly the recommended one, but I
relaxed a few rules.
2023-04-26 22:08:16 -04:00
silverwind b81217e206
Add all `no-query` rules to eslint config (#24294)
Add rules of the `no-jquery` plugin to the config and enable all non-violating ones.
2023-04-23 17:50:44 -04:00
yp05327 8ea33baa1c
Introduce eslint-plugin-no-jquery/no-event-shorthand (#24198)


Co-authored-by: silverwind <>
2023-04-20 05:28:27 -04:00
silverwind 92e07f270a
Update JS dependencies (#24218)
- Update all js dependencies, update playwright image to jammy
- Adjust eslint and vitest config
- Tested build, monaco, mermaid, katex
2023-04-19 22:36:41 -04:00
silverwind 3037922a9b
Add eslint-plugin-custom-elements (#23991)
and enable all rules that I've found sensible.
2023-04-08 05:24:42 -04:00
silverwind ae36113568
Remove jQuery ready usage (#23858)
Replace it with equal function of our own and enable the eslint rule to
forbid future usage.
2023-04-01 18:40:22 -04:00
wxiaoguang d32af84a10
Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950)
Close #22847

This PR:

* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none 

From now on:

do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"

only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"

cc: @silverwind , this is the all-in-one PR
2023-02-19 12:06:14 +08:00
silverwind a1fcb1cfb8
Update JS dependencies (#22538)
- Update all JS dependencies
- Add new eslint rules
- Rebuild SVGs
- Tested citation and build

SVG changes are because of

Co-authored-by: techknowlogick <>
2023-01-21 10:42:13 +08:00
silverwind e767b3372a
Update JS dependencies and eslint (#22190)
- Update all JS dependencies to latest version
- Enable unicorn/prefer-node-protocol and autofix issues
- Regenerate SVGs
- Add some comments to eslint rules
- Tested build, Mermaid and Katex rendering
2022-12-20 17:15:47 -05:00
silverwind c8b217110b
Update JS dependencies (#21881)
- Update all JS deps
- Regenerate SVGs
- Add new eslint rules, fix issues
- Tested Mermaid, Swagger, Vue, Webpack, Citation

Co-authored-by: Lunny Xiao <>
2022-11-22 08:58:55 +08:00
silverwind c2fb27beb4
Improvements for Content Copy (#21842)
It now supports copying Markdown, SVG and Images (not in Firefox
currently because of lacking
support, but can be enabled in `about:config` and works). It will fetch
the data if in a rendered view or when it's an image.

Followup to
2022-11-21 17:59:42 +08:00
silverwind b1dd1ba48f
Update JS dependencies and misc tweaks (#21583)
- Update all JS dependencies to latest version
- Disable two redundant eslint rules
- Adapt stylelint config to codebase
- Regenerate SVGs
- Make file editor spinner "reserve" height so page does not shift
- Tested katex, swagger, monaco

Co-authored-by: Lunny Xiao <>
Co-authored-by: 6543 <>
2022-10-28 09:40:50 -04:00
silverwind 37ca4cb7d6
Remove vitest globals (#21505)
Explicitly import them instead which is cleaner and enables better
editor integration.

Co-authored-by: Lunny Xiao <>
Co-authored-by: wxiaoguang <>
2022-10-19 14:50:19 +08:00
silverwind 7044d34ae5
Update JS dependencies and eslint config (#21388)
- Update all JS dependencies and playwright image
- Add new eslint rules, enable a few more, fix issues
- Regenerate SVGs
- Tested Vue and Swagger

Co-authored-by: wxiaoguang <>
2022-10-10 20:02:20 +08:00
silverwind ec82a24547
Update JS dependencies and lint (#21144)
- Update all JS dependencies minus vue
- Enable one more eslint rule, no new issues with it
- Tested build
2022-09-11 17:34:38 +02:00