test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Delete related notifications on issue deletion too (#18953) 

* use .Decr for issue comment counting

* Remove notification on issue removal
This commit is contained in:
Otto Richter (fnetX) 2022-03-17 23:04:09 +01:00 committed by GitHub
parent 45f8d97131
commit 04fcf23ea3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
models/issue.go
View File

@ -2124,6 +2124,7 @@ func deleteIssue(ctx context.Context, issue *Issue) error {
&IssueDependency{},
&IssueAssignees{},
&IssueUser{},
&Notification{},
&Reaction{},
&IssueWatch{},
&Stopwatch{},

2
models/issue_comment.go
View File

@ -1163,7 +1163,7 @@ func deleteComment(e db.Engine, comment *Comment) error {
}
if comment.Type == CommentTypeComment {
if _, err := e.Exec("UPDATE `issue` SET num_comments = num_comments - 1 WHERE id = ?", comment.IssueID); err != nil {
if _, err := e.ID(comment.IssueID).Decr("num_comments").Update(new(Issue)); err != nil {
return err
}
}