test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Fix counter display number incorrectly displayed on the page (#29448) (#29478) 

Backport #29448 by @charles7668

issue : #28239

The counter number script uses the 'checkbox' attribute to determine
whether an item is selected or not.

However, the input event only increments the counter value, and when
more items are displayed, it does not update all previously loaded
items.

As a result, the display becomes incorrect because it triggers the
update counter script, but checkboxes that are selected without the
'checked' attribute are not counted

Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
This commit is contained in:
Giteabot 2024-02-29 06:13:49 +08:00 committed by GitHub
parent b43ce53a23
commit 5477728282
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web_src/js/features/pull-view-file.js
View File

@ -44,9 +44,11 @@ export function initViewedCheckboxListenerFor() {
// Mark the file as viewed visually - will especially change the background // Mark the file as viewed visually - will especially change the background
if (this.checked) { if (this.checked) {
form.classList.add(viewedStyleClass); form.classList.add(viewedStyleClass);
checkbox.setAttribute('checked', '');
prReview.numberOfViewedFiles++; prReview.numberOfViewedFiles++;
} else { } else {
form.classList.remove(viewedStyleClass); form.classList.remove(viewedStyleClass);
checkbox.removeAttribute('checked');
prReview.numberOfViewedFiles--; prReview.numberOfViewedFiles--;
} }