test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Avoid extra loop

This commit is contained in:
Manush Dodunekov 2020-01-09 01:37:39 +01:00
parent 7d17aad805
commit 7d74b8596c
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
models/access.go
View File

@ -191,21 +191,16 @@ func (repo *Repository) refreshAccesses(e Engine, accessMap map[int64]*userAcces
minMode = AccessModeWrite minMode = AccessModeWrite
} }
// build a map of the actual entries we want to create newAccesses := make([]Access, 0, len(accessMap))
entryMap := make(map[int64]AccessMode, len(accessMap))
for userID, ua := range accessMap { for userID, ua := range accessMap {
if ua.Mode < minMode && !ua.User.IsRestricted { if ua.Mode < minMode && !ua.User.IsRestricted {
continue continue
} }
entryMap[userID] = ua.Mode
}
newAccesses := make([]Access, 0, len(entryMap))
for userID, mode := range entryMap {
newAccesses = append(newAccesses, Access{ newAccesses = append(newAccesses, Access{
UserID: userID, UserID: userID,
RepoID: repo.ID, RepoID: repo.ID,
Mode: mode, Mode: ua.Mode,
}) })
} }