test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Fix 'add code comment' button being invisible all the time (#13389) 

* Fix 'add code comment' button being invisible all the time

* Fix off-center icon

* Remove old JS hover hack

* Show on full-line hover

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This commit is contained in:
Cirno the Strongest 2020-11-02 16:58:14 +01:00 committed by GitHub
parent 06268dcf53
commit 7f7e7f3ca4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
web_src/js/index.js
View File

@ -1238,16 +1238,6 @@ function initPullRequestReview() {
$(this).closest('.menu').toggle('visible'); $(this).closest('.menu').toggle('visible');
}); });
$('.code-view .lines-code,.code-view .lines-num')
.on('mouseenter', function () {
const parent = $(this).closest('td');
$(this).closest('tr').addClass(
parent.hasClass('lines-num-old') || parent.hasClass('lines-code-old') ? 'focus-lines-old' : 'focus-lines-new'
);
})
.on('mouseleave', function () {
$(this).closest('tr').removeClass('focus-lines-new focus-lines-old');
});
$('.add-code-comment').on('click', function (e) { $('.add-code-comment').on('click', function (e) {
if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745 if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745
e.preventDefault(); e.preventDefault();

11
web_src/less/_review.less
View File

@ -1,7 +1,7 @@
.ui.button.add-code-comment { .ui.button.add-code-comment {
font-size: 14px; font-size: 14px;
height: 16px; height: 16px;
line-height: 16px !important; line-height: 12px !important;
padding: 0; padding: 0;
position: relative; position: relative;
width: 16px; width: 16px;
@ -17,6 +17,10 @@
} }
} }
.diff-file-box .lines-code:hover .ui.button.add-code-comment {
opacity: 1;
}
.repository .diff-file-box .code-diff .add-comment-left, .repository .diff-file-box .code-diff .add-comment-left,
.repository .diff-file-box .code-diff .add-comment-right, .repository .diff-file-box .code-diff .add-comment-right,
.repository .diff-file-box .code-diff .add-code-comment .add-comment-left, .repository .diff-file-box .code-diff .add-code-comment .add-comment-left,
@ -40,11 +44,6 @@
} }
} }
.focus-lines-new .ui.button.add-code-comment.add-code-comment-right,
.focus-lines-old .ui.button.add-code-comment.add-code-comment-left {
opacity: 1;
}
.comment-code-cloud { .comment-code-cloud {
padding: 4px; padding: 4px;
padding-left: 0; padding-left: 0;