test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Fix double-indirection bug in logging IDs (#12294) (#12308) 

This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
techknowlogick 2020-07-23 19:24:22 -04:00 committed by GitHub
parent 64eaa2a942
commit 8d1cd4d252
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/log/colors.go
View File

@ -355,7 +355,7 @@ func NewColoredValueBytes(value interface{}, colorBytes *[]byte) *ColoredValue {
// The Value will be colored with FgCyan // The Value will be colored with FgCyan
// If a ColoredValue is provided it is not changed // If a ColoredValue is provided it is not changed
func NewColoredIDValue(value interface{}) *ColoredValue { func NewColoredIDValue(value interface{}) *ColoredValue {
return NewColoredValueBytes(&value, &fgCyanBytes) return NewColoredValueBytes(value, &fgCyanBytes)
} }
// Format will format the provided value and protect against ANSI color spoofing within the value // Format will format the provided value and protect against ANSI color spoofing within the value