test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Remove redundant nil check in `WalkGitLog` (#26773) 

From the Go specification:

> "1. For a nil slice, the number of iterations is 0."
https://go.dev/ref/spec#For_range

Therefore, an additional nil check for before the loop is unnecessary.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun 2023-08-29 19:03:43 +08:00 committed by GitHub
parent db09b35590
commit ad3cbbc3b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/git/log_name_status.go
View File

@ -374,7 +374,6 @@ heaploop:
break heaploop break heaploop
} }
parentRemaining.Remove(current.CommitID) parentRemaining.Remove(current.CommitID)
if current.Paths != nil {
for i, found := range current.Paths { for i, found := range current.Paths {
if !found { if !found {
continue continue
@ -397,7 +396,6 @@ heaploop:
} }
} }
} }
}
if remaining <= 0 { if remaining <= 0 {
break heaploop break heaploop