test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

Prevent primary key update on migration (#26192) (#26199) 

Backport #26192 by @KN4CK3R

Fixes #25918

The migration fails on MSSQL because xorm tries to update the primary
key column. xorm prevents this if the column is marked as auto
increment:

c622cdaf89/internal/statements/update.go (L38-L40)

I think it would be better if xorm would check for primary key columns
here because updating such columns is bad practice. It looks like if
that auto increment check should do the same.

fyi @lunny

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
This commit is contained in:
Giteabot 2023-07-28 17:08:11 +08:00 committed by GitHub
parent 892e24aaf1
commit ecfbcced46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
models/migrations/v1_20/v250.go
View File

@ -20,7 +20,7 @@ func ChangeContainerMetadataMultiArch(x *xorm.Engine) error {
} }
type PackageVersion struct { type PackageVersion struct {
ID int64 `xorm:"pk"` ID int64 `xorm:"pk autoincr"`
MetadataJSON string `xorm:"metadata_json"` MetadataJSON string `xorm:"metadata_json"`
} }