a223bc8765
Prevent 500 when there is an error during new auth source post ( #19041 )
...
Fix #19036
Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-03-10 23:40:43 +01:00
886b1de949
Update the webauthn_credential_id_sequence in Postgres ( #19048 )
...
* Update the webauthn_credential_id_sequence in Postgres
There is (yet) another problem with v210 in that Postgres will silently allow preset
ID insertions ... but it will not update the sequence value.
This PR simply adds a little step to the end of the v210 migration to update the
sequence number.
Users who have already migrated who find that they cannot insert new
webauthn_credentials into the DB can either run:
```bash
gitea doctor recreate-table webauthn_credential
```
or
```bash
./gitea doctor --run=check-db-consistency --fix
```
which will fix the bad sequence.
Fix #19012
Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-03-10 23:04:55 +01:00
a0db075f21
If rendering has failed due to a net.OpError stop rendering (attempt 2) ( #19049 )
...
Unfortunately #18642 does not work because a `*net.OpError` does not implement
the `Is` interface to make `errors.Is` work correctly - thus leading to the
irritating conclusion that a `*net.OpError` is not a `*net.OpError`.
Here we keep the `errors.Is` because presumably this will be fixed at
some point in the golang main source code but also we add a simply type
cast to also check.
Fix #18629
Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-03-10 20:23:15 +00:00
ba470a85dd
use xorm builder for models.getReviewers() ( #19033 )
...
* xorm builder
* dedup code
2022-03-10 19:12:10 +01:00
cc98737ca8
RSS/Atom support for Orgs ( #17714 )
...
part of #569
2022-03-10 15:54:51 +01:00
5fdd30423e
Fix flag validation ( #19046 )
...
Regression from #5785
2022-03-10 10:11:26 +00:00
75eb6cc9c1
Improve SyncMirrors logging ( #19045 )
...
Yet another issue has come up where the logging from SyncMirrors does not provide
enough context. This PR adds more context to these logging events.
Related #19038
Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-03-10 10:09:48 +00:00
1314f38b59
fix pam authorization ( #19040 )
...
https://huntr.dev/bounties/8d221f92-b2b1-4878-bc31-66ff272e5ceb/
Co-authored-by: ysf <34326+ysf@users.noreply.github.com>
2022-03-10 10:00:05 +08:00
7443213707
[skip ci] Updated translations via Crowdin
2022-03-10 00:11:57 +00:00
Lunny Xiao
2448c5ad8b
Upgrading binding package ( #19034 )
...
Fix #18855
2022-03-09 18:06:58 +00:00
c21735b49a
Ensure isSSH is set whenever DISABLE_HTTP_GIT is set ( #19028 )
...
When DISABLE_HTTP_GIT is set we should always show the SSH button
2022-03-09 12:42:29 +08:00
ea46142bce
Add button for issue deletion ( #19032 )
...
Co-authored-by: Norwin <noerw@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2022-03-09 01:38:11 +01:00
ddf7f1319f
Fix script compatiable with OpenWrt ( #19000 )
...
* Fix compatibility of upgrade.sh in openwrt and add service init script for openwrt.
* Apply suggestions from code review
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: zeripath <art27@cantab.net>
* Update contrib/upgrade.sh
Co-authored-by: Norwin <noerw@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Norwin <noerw@users.noreply.github.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2022-03-08 17:58:14 -05:00
eceab9e26f
Allow users to self-request a PR review ( #19030 )
...
The review request feature was added in https://github.com/go-gitea/gitea/pull/10756 ,
where the doer got explicitly excluded from available reviewers. I don't see a
functionality or security related reason to forbid this case.
As shown by GitHubs implementation, it may be useful to self-request a review,
to be reminded oneselves about reviewing, while communicating to team mates that a
review is missing.
Co-authored-by: delvh <dev.lh@web.de>
2022-03-08 22:48:47 +01:00
e73c5fd698
Fix wrong scopes caused by empty scope input ( #19029 )
2022-03-08 19:56:40 +01:00
bbce905b6a
Feature: show issue assignee on project board ( #15232 )
...
* Show assignees in project boards.
2022-03-09 00:42:28 +08:00
1546580f9e
bump go deps ( #19021 )
...
* update gitea.com/go-chi/binding
* update gitea.com/go-chi/cache
* update github.com/42wim/sshsig
* update github.com/PuerkitoBio/goquery
* update github.com/blevesearch/bleve/v2
* update github.com/caddyserver/certmagic
* update github.com/denisenkom/go-mssqldb
* update github.com/duo-labs/webauthn
* update github.com/dustin/go-humanize
* update github.com/editorconfig/editorconfig-core-go/v2
* update github.com/ethantkoenig/rupture
* update github.com/go-chi/chi/v5
* update github.com/go-git/go-git/v5
* update github.com/go-ldap/ldap/v3
* update github.com/go-redis/redis/v8
* update github.com/go-swagger/go-swagger
* update github.com/gogs/chardet
* update github.com/golang-jwt/jwt/v4
* update github.com/hashicorp/go-version
* update github.com/jaytaylor/html2text
* update github.com/klauspost/compress
* update github.com/lib/pq
* update github.com/markbates/goth
* update github.com/mattn/go-sqlite3
* update github.com/mholt/archiver/v3
* update github.com/microcosm-cc/bluemonday
* update github.com/minio/minio-go/v7
* update github.com/msteinert/pam
* update github.com/niklasfasching/go-org
* update github.com/olivere/elastic/v7
* update github.com/prometheus/client_golang
* update github.com/quasoft/websspi
* update github.com/stretchr/testify
* update github.com/unknwon/i18n
* update github.com/unrolled/render
* update github.com/xanzy/go-gitlab
* update github.com/yuin/goldmark
* update github.com/yuin/goldmark-highlighting
* update github.com/yuin/goldmark-meta
* post make vendor
Signed-off-by: Andrew Thornton <art27@cantab.net>
* add make vendor back into update_dependencies.sh
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update update_dependencies.sh
* Update contrib/update_dependencies.sh
Co-authored-by: zeripath <art27@cantab.net>
* update mvdan.cc/xurls/v2
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2022-03-08 19:15:30 +08:00
8ddb5490e8
Don't show context cancelled errors in attribute reader ( #19006 )
...
Fix #18997
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2022-03-08 08:30:14 +00:00
78b38a5ccc
Set `rel="nofollow noindex"` on new issue links ( #19023 )
...
Fix #19018
Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-03-07 17:08:05 -05:00
9c5696e428
update to correct stable version
2022-03-07 02:03:06 -05:00
98f54081d6
[skip ci] Updated translations via Crowdin
2022-03-07 00:11:49 +00:00
cc643284de
Add Index to comment for migrations and mirroring ( #18806 )
...
Comments have an id (see Gitea[0], GitLab[1], GitHub[2], etc.), and the
comment migration format must represent it during migrations so that
it can be used during mirroring or incremental migrations.
[0] https://try.gitea.io/api/swagger#/issue/issueGetComment
[1] https://docs.gitlab.com/ee/api/discussions.html#get-single-issue-discussion-item
[2] https://docs.github.com/en/rest/reference/issues#get-an-issue-comment
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
2022-03-06 20:00:41 +01:00
Lunny Xiao
b24e8d38af
Support ignore all santize for external renderer ( #18984 )
...
* Support ignore all santize for external renderer
* Update docs
* Apply suggestions from code review
Co-authored-by: silverwind <me@silverwind.io>
* Fix doc
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: 6543 <6543@obermui.de>
2022-03-06 16:41:54 +08:00
3e28fa72ce
Fix EasyMDE error when input Enter ( #19004 )
...
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-06 01:53:34 +08:00
Lunny Xiao
814750e647
Fix update hint bug ( #18996 )
2022-03-04 20:59:29 +00:00
997deecbfa
Fix the editor height in review box ( #19003 )
...
Fix the height problem in https://github.com/go-gitea/gitea/pull/18862#issuecomment-1059329539
I have tested this fix.
# Screenshots
### Min-height
<img width="1138" alt="image" src="https://user-images.githubusercontent.com/2114189/156811831-93d4d31a-1b0a-4c4c-a7b4-fafc706133d6.png ">
### Max-height
<img width="1126" alt="image" src="https://user-images.githubusercontent.com/2114189/156811889-10ae41de-c63b-45e7-9d89-21a1ed29e58b.png ">
2022-03-04 20:57:26 +00:00
95c8d53d28
Add a "admin user generate-access-token" subcommand ( #17722 )
...
* Add a "admin user generate-access-token" subcommand
Fixes #17721
* Update cmd/admin.go
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Update cmd/admin.go
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
* Fix code to match new interfaces
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
2022-03-04 19:53:35 +00:00
e46a8c90ea
Fix potential assignee query for repo ( #18994 )
...
* Fix potential assignee query for repo
* Add tests for `GetRepoAssignees`
- As per https://github.com/go-gitea/gitea/pull/18994#issuecomment-1058506640
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-04 18:29:12 +00:00
5184c83f6b
Add config option to disable "Update branch by rebase" ( #18745 )
2022-03-04 03:30:49 -05:00
3c7201682c
Update `go-enry` to v2.8.0 ( #18993 )
...
- It was reported in the Matrix channel that Chroma [has support](d4021029760affa3ccca
2022-03-04 01:56:31 +01:00
286355c754
homebrew updates via cron
2022-03-03 15:59:26 -05:00
7a893dab39
ignore missing comment for user notifications ( #18954 )
...
* ignore missing comment for user notifications
* instead fix bug in notifications model
* use local variable instead
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
2022-03-03 16:18:26 +01:00
e800bc0cf4
allow overwrite artifacts for github releases ( #18987 )
2022-03-03 15:28:41 +01:00
eddd2fb242
fix & refactor ( #18973 )
...
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-03 19:51:13 +08:00
f3cbdee38e
Don't clean up hardcoded `tmp` ( #18983 )
...
* Don't clean up hardcoded `tmp`.
* Fixed import.
2022-03-02 23:50:29 +01:00
efd10f1ab4
git backend ignore replace objects ( #18979 )
...
* git backend ignore replace objects
* comment
2022-03-02 20:13:19 +00:00
Lunny Xiao
04971c33a3
Improve the deletion of issue ( #18945 )
...
Co-authored-by: 6543 <6543@obermui.de>
2022-03-02 18:38:56 +01:00
f8898c30dc
Add note to GPG key response if user has no keys ( #18961 )
...
* Prevent invalid key response.
* Display note instead of 404 response.
* Fixed test.
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2022-03-02 11:32:18 -05:00
df9802ca61
adds restore docs for docker based instances ( #18844 )
...
* adds docke restore section
* fix typo
* Update docs/content/doc/usage/backup-and-restore.en-us.md
Co-authored-by: Gusted <williamzijl7@hotmail.com>
* fix container id placeholder
* adds restore help for docker-rootless
* restore yml autoformater quotes
Co-authored-by: Marco Blessing <marco.blessing@komm.one>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2022-03-02 11:20:00 -05:00
dd712b77f7
Refactor admin user filter query parameters ( #18965 )
...
Only pass `status_filter` on admin page
Use a more general method to pass query parameters, remove hard-coded keys
2022-03-02 16:30:14 +01:00
a14b6f3aae
Refactor mirror code & fix `StartToMirror` ( #18904 )
...
* Use MirrorID instead of RepoID
- Use the MirrorID as index(SQL uses `id` column not the `repo_id`).
Passes the Mirror ID's into the Sync functions.
* Check for MirrorID == 0
* Fix `StartToMirror` + refactor
* Update services/mirror/mirror.go
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-02 15:43:11 +08:00
a90041d71a
Send 404 on `/{org}.gpg` ( #18959 )
2022-03-01 20:37:32 -05:00
1f45d1e130
Accounts with WebAuthn only (no TOTP) now exist ... fix code to handle that case ( #18897 )
2022-03-02 01:24:31 +01:00
Lunny Xiao
38f6322164
Fix lfs management setting ( #18946 )
...
Fix #18782
2022-03-01 23:14:27 +00:00
aee0fa68a7
Fix admin user list pagination ( #18957 )
2022-03-01 20:21:37 +01:00
062fd4c217
[API] Allow removing issues ( #18879 )
...
Add new feature to delete issues and pulls via API
Co-authored-by: fnetx <git@fralix.ovh>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: 6543 <6543@obermui.de>
2022-03-01 01:20:15 +01:00
6859b69198
Refactor SecToTime() function ( #18863 )
...
- Add helper method to reduce redundancy
- Expand the scope from displaying days to years
- Reduce irrelevance by not displaying small units (hours, minutes, seconds) when bigger ones apply (years)
2022-02-28 23:57:20 +01:00
Lunny Xiao
b75ad7b87f
Improve mirror iterator ( #18928 )
...
* Improve mirror iterator
* fix test
2022-02-28 20:41:06 +01:00
Lunny Xiao
59959ab222
Fix login with email panic when email is not exist ( #18941 )
2022-02-28 18:33:33 +01:00
4697735c8d
Adjust error for already locked db and prevent level db lock on malformed connstr ( #18923 )
...
This PR adjusts the error returned when there is failure to lock the level db, and
permits a connections to the same leveldb where there is a different connection string.
Reference #18921
Reference #18917
Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-02-27 19:45:06 +00:00
zeripath
Lunny Xiao
