forked from gitea/gitea
		
	 63a401ac40
			
		
	
	
		63a401ac40
		
			
		
	
	
	
	
		
			
			This PR moves the secrets and runners settings to actions settings on
all settings(repo,org,user,admin) levels.
After this PR, if
[ENABLED](5e7543fcf4/custom/conf/app.example.ini (L2604))
inside `app.ini` under `[actions]` is set to `false`, the "Actions" tab
(including runners management and secrets management) will not be shown.
After, the settings under actions settings for each level:
1. Admin Level
"Runners Management"
<img width="1437" alt="Screen Shot 2023-04-26 at 14 34 20"
src="https://user-images.githubusercontent.com/17645053/234489731-15822d21-38e1-4560-8bbe-69f122376abc.png">
2. User Level
"Secrets Management"
<img width="1427" alt="Screen Shot 2023-04-26 at 14 34 30"
src="https://user-images.githubusercontent.com/17645053/234489795-68c9c0cb-24f8-4f09-95c6-458ab914c313.png">
3. Repo and Organization Levels
"Runners Management" and "Secrets Management" 
   Org:
<img width="1437" alt="Screen Shot 2023-04-26 at 14 35 07"
src="https://user-images.githubusercontent.com/17645053/234489996-f3af5ebb-d354-46ca-9087-a0b586845281.png">
<img width="1433" alt="Screen Shot 2023-04-26 at 14 35 14"
src="https://user-images.githubusercontent.com/17645053/234490004-3abf8fed-81fd-4ce2-837a-935dade1793d.png">
    Repo:
<img width="1419" alt="Screen Shot 2023-04-26 at 14 34 50"
src="https://user-images.githubusercontent.com/17645053/234489904-80c11038-4b58-462c-9d0b-8b7cf70bc2b3.png">
    
<img width="1430" alt="Screen Shot 2023-04-26 at 14 34 57"
src="https://user-images.githubusercontent.com/17645053/234489918-4e8d1fe2-9bcd-4d8a-96c1-238a8088d92e.png">
It also finished these tasks :
- [x] rename routers function "runners" to "actions", and refactor
related file names
- [x] check and modify part of the runners related functions to match
their name
- [x] Fix backend check caused by fmt check
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
		
	
			
		
			
				
	
	
		
			168 lines
		
	
	
		
			4.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			168 lines
		
	
	
		
			4.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2022 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package setting
 | |
| 
 | |
| import (
 | |
| 	"errors"
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 
 | |
| 	actions_model "code.gitea.io/gitea/models/actions"
 | |
| 	"code.gitea.io/gitea/models/db"
 | |
| 	"code.gitea.io/gitea/modules/base"
 | |
| 	"code.gitea.io/gitea/modules/context"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	actions_shared "code.gitea.io/gitea/routers/web/shared/actions"
 | |
| )
 | |
| 
 | |
| const (
 | |
| 	// TODO: Separate secrets from runners when layout is ready
 | |
| 	tplRepoRunners     base.TplName = "repo/settings/actions"
 | |
| 	tplOrgRunners      base.TplName = "org/settings/actions"
 | |
| 	tplAdminRunners    base.TplName = "admin/actions"
 | |
| 	tplRepoRunnerEdit  base.TplName = "repo/settings/runner_edit"
 | |
| 	tplOrgRunnerEdit   base.TplName = "org/settings/runners_edit"
 | |
| 	tplAdminRunnerEdit base.TplName = "admin/runners/edit"
 | |
| )
 | |
| 
 | |
| type runnersCtx struct {
 | |
| 	OwnerID            int64
 | |
| 	RepoID             int64
 | |
| 	IsRepo             bool
 | |
| 	IsOrg              bool
 | |
| 	IsAdmin            bool
 | |
| 	RunnersTemplate    base.TplName
 | |
| 	RunnerEditTemplate base.TplName
 | |
| 	RedirectLink       string
 | |
| }
 | |
| 
 | |
| func getRunnersCtx(ctx *context.Context) (*runnersCtx, error) {
 | |
| 	if ctx.Data["PageIsRepoSettings"] == true {
 | |
| 		return &runnersCtx{
 | |
| 			RepoID:             ctx.Repo.Repository.ID,
 | |
| 			OwnerID:            0,
 | |
| 			IsRepo:             true,
 | |
| 			RunnersTemplate:    tplRepoRunners,
 | |
| 			RunnerEditTemplate: tplRepoRunnerEdit,
 | |
| 			RedirectLink:       ctx.Repo.RepoLink + "/settings/actions/runners/",
 | |
| 		}, nil
 | |
| 	}
 | |
| 
 | |
| 	if ctx.Data["PageIsOrgSettings"] == true {
 | |
| 		return &runnersCtx{
 | |
| 			RepoID:             0,
 | |
| 			OwnerID:            ctx.Org.Organization.ID,
 | |
| 			IsOrg:              true,
 | |
| 			RunnersTemplate:    tplOrgRunners,
 | |
| 			RunnerEditTemplate: tplOrgRunnerEdit,
 | |
| 			RedirectLink:       ctx.Org.OrgLink + "/settings/actions/runners/",
 | |
| 		}, nil
 | |
| 	}
 | |
| 
 | |
| 	if ctx.Data["PageIsAdmin"] == true {
 | |
| 		return &runnersCtx{
 | |
| 			RepoID:             0,
 | |
| 			OwnerID:            0,
 | |
| 			IsAdmin:            true,
 | |
| 			RunnersTemplate:    tplAdminRunners,
 | |
| 			RunnerEditTemplate: tplAdminRunnerEdit,
 | |
| 			RedirectLink:       setting.AppSubURL + "/admin/actions/runners/",
 | |
| 		}, nil
 | |
| 	}
 | |
| 
 | |
| 	return nil, errors.New("unable to set Runners context")
 | |
| }
 | |
| 
 | |
| // Runners render settings/actions/runners page for repo level
 | |
| func Runners(ctx *context.Context) {
 | |
| 	ctx.Data["PageIsSharedSettingsRunners"] = true
 | |
| 	ctx.Data["Title"] = ctx.Tr("actions.actions")
 | |
| 	ctx.Data["PageType"] = "runners"
 | |
| 
 | |
| 	rCtx, err := getRunnersCtx(ctx)
 | |
| 	if err != nil {
 | |
| 		ctx.ServerError("getRunnersCtx", err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	page := ctx.FormInt("page")
 | |
| 	if page <= 1 {
 | |
| 		page = 1
 | |
| 	}
 | |
| 
 | |
| 	opts := actions_model.FindRunnerOptions{
 | |
| 		ListOptions: db.ListOptions{
 | |
| 			Page:     page,
 | |
| 			PageSize: 100,
 | |
| 		},
 | |
| 		Sort:   ctx.Req.URL.Query().Get("sort"),
 | |
| 		Filter: ctx.Req.URL.Query().Get("q"),
 | |
| 	}
 | |
| 	if rCtx.IsRepo {
 | |
| 		opts.RepoID = rCtx.RepoID
 | |
| 		opts.WithAvailable = true
 | |
| 	} else if rCtx.IsOrg {
 | |
| 		opts.OwnerID = rCtx.OwnerID
 | |
| 		opts.WithAvailable = true
 | |
| 	}
 | |
| 	actions_shared.RunnersList(ctx, opts)
 | |
| 
 | |
| 	ctx.HTML(http.StatusOK, rCtx.RunnersTemplate)
 | |
| }
 | |
| 
 | |
| // RunnersEdit renders runner edit page for repository level
 | |
| func RunnersEdit(ctx *context.Context) {
 | |
| 	ctx.Data["PageIsSharedSettingsRunners"] = true
 | |
| 	ctx.Data["Title"] = ctx.Tr("actions.runners.edit_runner")
 | |
| 	rCtx, err := getRunnersCtx(ctx)
 | |
| 	if err != nil {
 | |
| 		ctx.ServerError("getRunnersCtx", err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	page := ctx.FormInt("page")
 | |
| 	if page <= 1 {
 | |
| 		page = 1
 | |
| 	}
 | |
| 
 | |
| 	actions_shared.RunnerDetails(ctx, page,
 | |
| 		ctx.ParamsInt64(":runnerid"), rCtx.OwnerID, rCtx.RepoID,
 | |
| 	)
 | |
| 	ctx.HTML(http.StatusOK, rCtx.RunnerEditTemplate)
 | |
| }
 | |
| 
 | |
| func RunnersEditPost(ctx *context.Context) {
 | |
| 	rCtx, err := getRunnersCtx(ctx)
 | |
| 	if err != nil {
 | |
| 		ctx.ServerError("getRunnersCtx", err)
 | |
| 		return
 | |
| 	}
 | |
| 	actions_shared.RunnerDetailsEditPost(ctx, ctx.ParamsInt64(":runnerid"),
 | |
| 		rCtx.OwnerID, rCtx.RepoID,
 | |
| 		rCtx.RedirectLink+url.PathEscape(ctx.Params(":runnerid")))
 | |
| }
 | |
| 
 | |
| func ResetRunnerRegistrationToken(ctx *context.Context) {
 | |
| 	rCtx, err := getRunnersCtx(ctx)
 | |
| 	if err != nil {
 | |
| 		ctx.ServerError("getRunnersCtx", err)
 | |
| 		return
 | |
| 	}
 | |
| 	actions_shared.RunnerResetRegistrationToken(ctx, rCtx.OwnerID, rCtx.RepoID, rCtx.RedirectLink)
 | |
| }
 | |
| 
 | |
| // RunnerDeletePost response for deleting runner
 | |
| func RunnerDeletePost(ctx *context.Context) {
 | |
| 	rCtx, err := getRunnersCtx(ctx)
 | |
| 	if err != nil {
 | |
| 		ctx.ServerError("getRunnersCtx", err)
 | |
| 		return
 | |
| 	}
 | |
| 	actions_shared.RunnerDeletePost(ctx, ctx.ParamsInt64(":runnerid"), rCtx.RedirectLink, rCtx.RedirectLink+url.PathEscape(ctx.Params(":runnerid")))
 | |
| }
 | |
| 
 | |
| func RedirectToDefaultSetting(ctx *context.Context) {
 | |
| 	ctx.Redirect(ctx.Repo.RepoLink + "/settings/actions/runners")
 | |
| }
 |