forked from gitea/gitea
1
0
Fork 0
gitea/modules/actions
Zettat123 2d91afaa92
Fix mismatch between hook events and github event types (#24048)
Some workflow trigger events can have multiple activity types, such as
`issues` and `pull_request`, and user can specify which types can
trigger the workflow. See GitHub documentation:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows

Now some hook events cannot match the workflow trigger events correctly
because we don't check the activity types. For example,
`pull_request_label` is an individual hook event. But there isn't a
`pull_request_label` workflow trigger event, we can only use
`pull_request` event's `label` activity type. If we don't check the
activity types, the workflows without the `label` activity type may be
triggered by the `pull_request_label` event by mistake. We need to
improve the match logic.

- [x] [`issues`
](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issues)
- [x]
[`issue_comment`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment)
- [x]
[`pull_request`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request)
- [x]
[`pull_request_review`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review)
- [x]
[`pull_request_review_comment`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review_comment)
- [x]
[`release`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release)
- [x]
[`registry_package`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#registry_package)
2023-04-12 12:16:47 -04:00
..
github.go Improve workflow event triggers (#23613) 2023-03-23 12:04:15 +08:00
github_test.go Improve workflow event triggers (#23613) 2023-03-23 12:04:15 +08:00
log.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
task_state.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
task_state_test.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
workflows.go Fix mismatch between hook events and github event types (#24048) 2023-04-12 12:16:47 -04:00
workflows_test.go Fix mismatch between hook events and github event types (#24048) 2023-04-12 12:16:47 -04:00