forked from gitea/gitea
1
0
Fork 0
gitea/tests
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
e2e Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
gitea-repositories-meta Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
integration test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
mssql.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
mysql.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
mysql8.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
pgsql.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
sqlite.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
test_utils.go Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
testlogger.go Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00