test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity
gitea/services/pull
History
qwerty287 9d943bf374
Add missing `X-Total-Count` and fix some related bugs (#17968) 
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
 		2021-12-15 13:39:34 +08:00
..
check.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
check_test.go Decouple unit test, remove intermediate `unittestbridge` package (#17662) 2021-11-16 16:53:21 +08:00
commit_status.go Add missing `X-Total-Count` and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
lfs.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
main_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
merge.go Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
patch.go Move unit into models/unit/ (#17576) 2021-11-09 20:57:58 +01:00
pull.go Add missing `X-Total-Count` and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
pull_test.go Append to existing trailers in generated squash commit message (#15980) 2021-06-25 13:01:43 -04:00
review.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
temp_repo.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
update.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00