forked from gitea/gitea
1
0
Fork 0
gitea/models/repo
oliverpool 8030614386
fix: release page for empty or non-existing target (#24470)
Fixes #24145

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release.
This is particularly useful if the target branch was deleted in the
meantime (or is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.
2023-05-10 11:43:55 +08:00
..
archiver.go Display when a repo was archived (#22664) 2023-04-26 10:46:26 -04:00
attachment.go Make Release Download URLs predictable (#23891) 2023-04-12 17:05:23 +08:00
attachment_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
avatar.go Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
collaboration.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
collaboration_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
fork.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fork_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
git.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
language_stats.go Round language stats percentage using largest remainder (#22026) 2022-12-08 10:47:47 +08:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mirror.go Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
pushmirror.go Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
pushmirror_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
redirect.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
redirect_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
release.go fix: release page for empty or non-existing target (#24470) 2023-05-10 11:43:55 +08:00
repo.go Fix unclear `IsRepositoryExist` logic (#24374) 2023-04-28 14:14:26 -04:00
repo_indexer.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_list.go Use context for `RepositoryList.LoadAttributes` (#23435) 2023-03-13 11:31:41 +00:00
repo_list_test.go fix calReleaseNumCommitsBehind (#24148) 2023-04-18 21:11:17 +02:00
repo_test.go Set repository link based on the url in package.json for npm packages (#20379) 2023-03-28 13:55:03 -04:00
repo_unit.go Pull Requests: setting to allow edits by maintainers by default, tweak UI (#22862) 2023-02-13 14:09:52 +08:00
search.go Split "modules/context.go" to separate files (#24569) 2023-05-08 17:36:54 +08:00
star.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
star_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
topic.go Sort repo topic labels by name (#24123) 2023-04-14 15:29:05 -04:00
topic_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
update.go Fix unclear `IsRepositoryExist` logic (#24374) 2023-04-28 14:14:26 -04:00
upload.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_repo.go Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890) 2023-04-07 08:11:02 +08:00
user_repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
watch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
watch_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00