forked from gitea/gitea
1
0
Fork 0
gitea/modules
zeripath 659b946eda
Fix missing close in WalkGitLog (#17008) (#17009)
Backport #17008

When the external context is cancelled it is possible for the
GitLogReader to not itself be Closed.

This PR does three things:

1. Instead of adding a plain defer it wraps the `g.Close` in a func as
`g` may change.
2. It adds the missing explicit g.Close - although the defer fix makes
this unnecessary.
3. It passes down the external context as the base context for the
GitLogReader meaning that the cancellation of the external context will
pass down automatically.

Fix #17007

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-10 17:46:06 +08:00
..
analyze Speed up `enry.IsVendor` (#15213) 2021-04-01 19:41:09 +02:00
auth Lock goth/gothic and Re-attempt OAuth2 registration on login if registration failed at startup (#16570) 2021-07-29 18:52:38 +01:00
avatar Add Image Diff for SVG files (#14867) 2021-06-05 15:32:19 +03:00
base Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
cache Add LRU mem cache implementation (#16226) 2021-07-10 23:54:15 +02:00
charset Refactor renders (#15175) 2021-04-19 18:25:08 -04:00
context Pass down SignedUserName down to AccessLogger context (#16605) (#16616) 2021-08-04 13:26:35 -04:00
convert Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
cron Fix archive error when rename repo or user (#16399) 2021-07-13 14:16:31 +02:00
csv Refactor renders (#15175) 2021-04-19 18:25:08 -04:00
doctor Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) (#16977) 2021-09-07 19:39:05 +01:00
emoji Run processors on whole of text (#16155) 2021-06-17 11:35:05 +01:00
eventsource Hold the event source when there are no listeners (#15725) 2021-05-15 23:46:13 +02:00
generate Switch to maintained jwt lib (#16532) (#16533) 2021-07-24 11:13:50 -04:00
git Fix missing close in WalkGitLog (#17008) (#17009) 2021-09-10 17:46:06 +08:00
gitgraph Fix bug on commit graph (#15517) 2021-04-17 10:27:25 +01:00
graceful Support HTTP/2 in Let's Encrypt (#16371) 2021-07-13 18:17:46 +01:00
hcaptcha hCaptcha Support (#12594) 2020-10-02 23:37:53 -04:00
highlight Ensure empty lines are copiable and final new line too (#16678) (#16692) 2021-08-15 05:39:23 +02:00
httpcache Add ETag header (#15370) 2021-04-12 10:49:26 -04:00
httplib Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
indexer Fix data race in bleve indexer (#16474) (#16509) 2021-07-22 11:42:32 +08:00
lfs Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
log Fix race in log (#16490) (#16505) 2021-07-21 20:19:36 +08:00
markup In Render tolerate not being passed a context (#16842) (#16858) 2021-08-29 15:25:45 +01:00
matchlist Add Allow-/Block-List for Migrate & Mirrors (#13610) 2020-11-28 19:37:58 -05:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
migrations Ignore review comment when ref commit is missed (#16905) (#16919) 2021-09-02 11:51:32 +01:00
nosql Fix setting redis db path (#15698) 2021-05-03 13:24:24 -04:00
notification Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
options Add StatDir and replace com.StatDir (#14099) 2020-12-22 07:40:57 +08:00
password Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
pprof Add golangci (#6418) 2019-06-12 15:41:28 -04:00
private Fix dump and restore respository (#16698) (#16898) 2021-08-31 10:44:14 +01:00
process Code Formats, Nits & Unused Func/Var deletions (#15286) 2021-04-09 09:40:34 +02:00
public Improve assets handler middleware (#15961) 2021-05-30 18:25:11 +08:00
queue Fix race in log (#16490) (#16505) 2021-07-21 20:19:36 +08:00
recaptcha Migrate to use jsoniter instead of encoding/json (#14841) 2021-03-01 22:08:10 +01:00
references Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repofiles Simplify split diff view generation and remove JS dependency (#16775) (#16863) 2021-08-30 16:43:06 +01:00
repository Report the correct number of pushes on the feeds (#16811) (#16822) 2021-08-26 02:30:13 -04:00
secret Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
session Migrate to use jsoniter instead of encoding/json (#14841) 2021-03-01 22:08:10 +01:00
setting Add LRU mem cache implementation (#16226) 2021-07-10 23:54:15 +02:00
ssh Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
storage Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) (#16977) 2021-09-07 19:39:05 +01:00
structs Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
svg Fix filepath basename on Windows for SVG bindata (#12241) 2020-07-13 21:16:40 +01:00
sync Fix missing unlock in uniquequeue (#9790) 2020-01-15 23:58:33 +02:00
task Fix bug of migrated repository not index (#16991) (#16996) 2021-09-09 07:02:22 +01:00
templates Report the correct number of pushes on the feeds (#16811) (#16822) 2021-08-26 02:30:13 -04:00
test Move middlewares to web/middleware (#14480) 2021-01-30 10:55:53 +02:00
timeutil Fix display since time round (#14226) 2021-01-28 13:29:22 +01:00
translation Use index of the supported tags to choose user lang (#15452) 2021-04-14 19:52:01 +01:00
typesniffer Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
upload Update golangci-lint to version 1.31.0 (#13102) 2020-10-11 21:27:20 +01:00
uri Dump github/gitlab/gitea repository data to a local directory and restore to gitea (#12244) 2020-12-27 11:34:19 +08:00
user Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
util Handle too long PR titles correctly (#16517) (#16549) 2021-07-26 17:49:48 +02:00
validation Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
web Restore CORS on git smart http protocol (#16496) (#16506) 2021-07-21 15:03:02 +01:00