forked from gitea/gitea
1
0
Fork 0
gitea/templates/repo/diff
silverwind e24f651c86
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.

Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.

- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).
2023-06-14 18:17:58 +00:00
..
blob_excerpt.tmpl Button and color enhancements (#24989) 2023-06-09 08:37:47 +00:00
box.tmpl Button and color enhancements (#24989) 2023-06-09 08:37:47 +00:00
comment_form.tmpl Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) 2023-04-03 18:06:57 +08:00
comment_form_datahandler.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
comments.tmpl Improve and fix bugs surrounding reactions (#24760) 2023-05-28 01:34:18 +00:00
compare.tmpl Use flex to align SVG and text (#25163) 2023-06-14 16:40:15 +00:00
conversation.tmpl Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393) 2023-04-29 07:35:59 -04:00
csv_diff.tmpl Fix CSV diff for added/deleted files (#21189) 2022-09-17 10:45:32 +08:00
escape_title.tmpl Switch Unicode Escaping to a VSCode-like system (#19990) 2022-08-13 19:32:34 +01:00
image_diff.tmpl Improve "new-menu" (#24465) 2023-05-01 12:08:37 -04:00
new_comment.tmpl Do not reload page after adding comments in Pull Request reviews (#13877) 2021-01-08 23:49:55 +02:00
new_review.tmpl Change form actions to fetch for submit review box (#25219) 2023-06-14 16:01:37 +08:00
options_dropdown.tmpl Expand/Collapse all changed files (#23639) 2023-04-09 21:11:02 +08:00
section_code.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
section_split.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
section_unified.tmpl Button and color enhancements (#24989) 2023-06-09 08:37:47 +00:00
stats.tmpl Group template helper functions, remove `Printf`, improve template error messages (#23982) 2023-04-08 21:15:22 +08:00
whitespace_dropdown.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00