forked from gitea/gitea
e46dbec294
* Move EventSource to SharedWorker (#12095) Backport #12095 Move EventSource to use a SharedWorker. This prevents issues with HTTP/1.1 open browser connections from preventing gitea from opening multiple tabs. Also allow setting EVENT_SOURCE_UPDATE_TIME to disable EventSource updating Fix #11978 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * Bugfix for shared event source For some reason our eslint configuration is not working correctly and a bug has become apparent when trying to backport this to 1.12. Signed-off-by: Andrew Thornton <art27@cantab.net> * Re-fix #12095 again Unfortunately some of the suggested changes to #12095 introduced bugs which due to caching behaviour of sharedworkers were not caught on simple tests. These are as follows: * Changing from simple for loop to use includes here: ```js register(port) { if (!this.clients.includes(port)) return; this.clients.push(port); port.postMessage({ type: 'status', message: `registered to ${this.url}`, }); } ``` The additional `!` prevents any clients from being added and should read: ```js if (this.clients.includes(port)) return; ``` * Dropping the use of jQuery `$(...)` selection and using DOM `querySelector` here: ```js async function receiveUpdateCount(event) { try { const data = JSON.parse(event.data); const notificationCount = document.querySelector('.notification_count'); if (data.Count > 0) { notificationCount.classList.remove('hidden'); } else { notificationCount.classList.add('hidden'); } notificationCount.text() = `${data.Count}`; await updateNotificationTable(); } catch (error) { console.error(error, event); } } ``` Requires that `notificationCount.text()` be changed to use `textContent` instead. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> |
||
|---|---|---|
| .. | ||
| advanced | ||
| features | ||
| help | ||
| installation | ||
| upgrade | ||
| usage | ||
| advanced.en-us.md | ||
| advanced.fr-fr.md | ||
| advanced.zh-cn.md | ||
| features.en-us.md | ||
| features.zh-cn.md | ||
| features.zh-tw.md | ||
| help.en-us.md | ||
| help.fr-fr.md | ||
| help.zh-cn.md | ||
| help.zh-tw.md | ||
| installation.en-us.md | ||
| installation.fr-fr.md | ||
| installation.zh-cn.md | ||
| installation.zh-tw.md | ||
| upgrade.en-us.md | ||
| upgrade.fr-fr.md | ||
| upgrade.zh-cn.md | ||
| upgrade.zh-tw.md | ||
| usage.en-us.md | ||
| usage.zh-cn.md | ||