forked from gitea/gitea
1
0
Fork 0
gitea/modules/indexer/code
Eng Zer Jun 8b0aaa5f86
test: use `T.TempDir` to create temporary test directory (#21043)
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
bleve.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
bleve_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
elastic_search.go Fix `dump-repo` git init, fix wrong error type for NullDownloader (#20182) 2022-07-01 07:48:25 +08:00
elastic_search_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
git.go Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
indexer.go Move almost all functions' parameter db.Engine to context.Context (#19748) 2022-05-20 22:08:52 +08:00
indexer_test.go Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
search.go Automatically pause queue if index service is unavailable (#15066) 2022-01-27 10:30:51 +02:00
wrapped.go Automatically pause queue if index service is unavailable (#15066) 2022-01-27 10:30:51 +02:00