forked from gitea/gitea
1
0
Fork 0
gitea/modules/git
zeripath 659b946eda
Fix missing close in WalkGitLog (#17008) (#17009)
Backport #17008

When the external context is cancelled it is possible for the
GitLogReader to not itself be Closed.

This PR does three things:

1. Instead of adding a plain defer it wraps the `g.Close` in a func as
`g` may change.
2. It adds the missing explicit g.Close - although the defer fix makes
this unnecessary.
3. It passes down the external context as the base context for the
GitLogReader meaning that the cancellation of the external context will
pass down automatically.

Fix #17007

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-10 17:46:06 +08:00
..
pipeline Use git log name-status in get last commit (#16059) 2021-06-21 01:00:46 +03:00
tests/repos Fix webhook commits wrong hash on HEAD reset (#16283) 2021-06-30 19:49:06 +02:00
README.md move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364) 2019-03-27 17:33:00 +08:00
batch_reader.go Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) (#16480) 2021-07-20 23:52:19 +02:00
blame.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
blame_test.go Ensure BlameReaders close at end of request (#12102) 2020-07-01 14:01:17 +01:00
blob.go Fix diff expansion is missing final line in a file (#16222) 2021-06-24 17:47:46 +02:00
blob_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
blob_nogogit.go Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) (#16900) 2021-08-31 16:06:01 +08:00
blob_test.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
command.go Limit stdout tracelog to actual stdout (#16258) 2021-06-26 13:47:56 +01:00
command_test.go Fix nondeterministic behavior (#9341) 2019-12-13 17:03:38 +08:00
commit.go Fix modified files list in webhooks when there is a space (#16288) 2021-07-02 21:23:37 +02:00
commit_convert_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info_gogit.go Make commit info cancelable (#16032) 2021-06-06 19:44:58 -04:00
commit_info_nogogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
commit_info_test.go Make commit info cancelable (#16032) 2021-06-06 19:44:58 -04:00
commit_reader.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
commit_test.go Fix modified files list in webhooks when there is a space (#16288) 2021-07-02 21:23:37 +02:00
diff.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
diff_test.go Fix a couple of CommentAsPatch issues. (#14804) 2021-02-27 19:46:14 +01:00
error.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 2021-06-23 17:08:26 -04:00
git.go Let package git depend on setting but not opposite (#15241) 2021-06-26 13:28:55 +02:00
git_test.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
hook.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache_gogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache_nogogit.go Fix panic in recursive cache (#16298) 2021-06-29 16:12:43 -04:00
lfs.go Let package git depend on setting but not opposite (#15241) 2021-06-26 13:28:55 +02:00
log_name_status.go Fix missing close in WalkGitLog (#17008) (#17009) 2021-09-10 17:46:06 +08:00
notes.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
notes_gogit.go Change the implementation of the go-git version of GetNote to mirror the non go-git version when passed a non-existent commit (#16658) (#16659) 2021-08-09 20:24:31 +01:00
notes_nogogit.go Use git log name-status in get last commit (#16059) 2021-06-21 01:00:46 +03:00
notes_test.go Change the implementation of the go-git version of GetNote to mirror the non go-git version when passed a non-existent commit (#16658) (#16659) 2021-08-09 20:24:31 +01:00
parse_gogit.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
parse_gogit_test.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
parse_nogogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
parse_nogogit_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
ref.go Multiple GitGraph improvements: Exclude PR heads, Add branch/PR links, Show only certain branches, (#12766) 2020-11-08 12:21:54 -05:00
remote.go Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
repo.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 2021-06-23 17:08:26 -04:00
repo_archive.go Rework repository archive (#14723) 2021-06-23 17:12:38 -04:00
repo_attribute.go go-version constraints ignore pre-releases (#13234) 2020-10-21 11:42:08 -04:00
repo_base_gogit.go Update Go-Git to take advantage of LargeObjectThreshold (#16316) 2021-06-30 22:58:45 +02:00
repo_base_nogogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
repo_blame.go Removed unnecessary conversions (#7557) 2019-07-23 19:50:39 +01:00
repo_blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blob_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blob_nogogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
repo_blob_test.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
repo_branch.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_branch_gogit.go More efficiently parse shas for shaPostProcessor (#16101) 2021-06-21 00:39:12 +02:00
repo_branch_nogogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
repo_branch_test.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_commit.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_commit_gogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
repo_commit_nogogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
repo_commit_test.go Fix webhook commits wrong hash on HEAD reset (#16283) 2021-06-30 19:49:06 +02:00
repo_commitgraph_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_compare.go Restore detection of branches are equal on compare page (#14586) 2021-02-16 16:39:45 +01:00
repo_compare_test.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 2020-08-11 21:05:34 +01:00
repo_gpg.go Sign merges, CRUD, Wiki and Repository initialisation with gpg key (#7631) 2019-10-16 14:42:42 +01:00
repo_hook.go move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364) 2019-03-27 17:33:00 +08:00
repo_index.go Be more strict with git arguments (#7715) 2019-08-05 21:39:39 +01:00
repo_language_stats.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_language_stats_gogit.go Speed up `enry.IsVendor` (#15213) 2021-04-01 19:41:09 +02:00
repo_language_stats_nogogit.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
repo_object.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repo_stats.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_stats_test.go Add top author stats to activity page (#9615) 2020-01-20 12:07:30 +02:00
repo_tag.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
repo_tag_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_tag_nogogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
repo_tag_test.go Create tag on ui (#13467) 2021-02-28 19:57:45 +00:00
repo_test.go Tests should use test files (#15801) 2021-05-09 17:20:33 +02:00
repo_tree.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_tree_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_tree_nogogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
sha1.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
sha1_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
sha1_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
submodule.go Compare SSH_DOMAIN when parsing submodule URLs (#12753) 2020-09-07 20:08:10 -04:00
submodule_test.go Compare SSH_DOMAIN when parsing submodule URLs (#12753) 2020-09-07 20:08:10 -04:00
tag.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
tag_test.go Fix git.parseTagData (#14105) 2020-12-22 21:44:25 +01:00
tree.go Add TestPrepareWikiFileName (#16487) (#16498) 2021-07-21 03:37:00 +01:00
tree_blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_blob_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_blob_nogogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_entry_mode.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_entry_nogogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
tree_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_nogogit.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
utils.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
utils_test.go Fix ref links in issue overviews for tags (#8742) 2020-05-14 18:55:43 -04:00

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.