forked from gitea/gitea
1
0
Fork 0
gitea/services
Jason Song 174213530d
Fix `Permission` in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
2023-06-22 13:08:08 +00:00
..
actions Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
agit Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
asymkey Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
attachment Preserve file size when creating attachments (#23406) 2023-03-12 03:48:07 -04:00
auth Change default email domain for LDAP users (#25425) 2023-06-22 08:16:12 +00:00
automerge Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
context Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
convert Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
cron Use the new download domain replace the old (#25405) 2023-06-21 03:11:17 +00:00
externalaccount Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
forms Remove "CHARSET" config option for MySQL, always use "utf8mb4" (#25413) 2023-06-21 10:49:25 +00:00
gitdiff Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
issue Add codeowners feature (#24910) 2023-06-08 16:56:05 +08:00
lfs Move some regexp out of functions (#25430) 2023-06-21 19:57:18 +00:00
mailer Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
markup Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
migrations Fix panic when migrating a repo from GitHub with issues (#25246) 2023-06-14 14:12:39 +08:00
mirror Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
org Refactor rename user and rename organization (#24052) 2023-05-21 23:13:47 +08:00
packages Add CRAN package registry (#22331) 2023-05-22 10:57:49 +08:00
pull Add codeowners feature (#24910) 2023-06-08 16:56:05 +08:00
release Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
repository Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
task Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
user Refactor rename user and rename organization (#24052) 2023-05-21 23:13:47 +08:00
webhook Fix `Permission` in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
wiki Improve wiki user title test (#24559) 2023-05-06 11:24:18 +00:00