forked from gitea/gitea
1
0
Fork 0
gitea/web_src/js/features
zeripath 10c9f96a1e
Fixed colour transparency regex matching in project board sorting (#22092) (#22437)
Backport #22092

As described in the linked issue (#22091), semi-transparent UI elements
would result in JS errors due to the fact that the CSS `backgroundColor`
element was being matched by the pattern
`^rgb\((\d+),\s*(\d+),\s*(\d+)\)$`, which does not take the alpha
channel into account.

I changed the pattern to `^rgba?\((\d+),\s*(\d+),\s*(\d+).*\)$`. This
new pattern accepts both `rgb` and `rgba` tuples, and ignores the alpha
channel (that little `.*` at the end) from the sorting criteria. The
reason why I chose to ignore alpha is because when it comes to kanban
colour sorting, only the hue is important; the order of the panels
should stay the same, even if some of them are transparent.

Alternative solutions were discussed in the bug report and are included
here for completeness:
1. Change the regex from ^rgb\((\d+),\s*(\d+),\s*(\d+)\)$ to
^rgba?\((\d+),\s*(\d+),\s*(\d+)(,\s*(\d+(\.\d+)?))?\)$ (alpha channel is
a float or NaN on 5th group) and include the alpha channel in the
sorting criteria.
2. Rethink on why you're reading colours out of the CSS in the first
place, then reformat this sorting procedure.

Fix #22091

Co-authored-by: MisterCavespider <deler.urist@tutanota.de>
2023-01-15 12:05:04 +00:00
..
admin Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
comp Add team member invite by email (#20307) 2022-10-19 14:40:28 +02:00
aria.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2022-06-03 17:38:26 -04:00
aria.md Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2022-06-03 17:38:26 -04:00
clipboard.js Replace fomantic popup module with tippy.js (#20428) 2022-08-09 14:37:34 +02:00
codeeditor.js Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) (#21738) 2022-11-09 21:19:44 +08:00
colorpicker.js Move jquery-minicolors to npm/webpack (#12305) 2020-07-29 14:44:23 -04:00
common-global.js Prevent NPE if trying to restore an already restored deleted branch (#21940) (#21944) 2022-11-25 17:28:03 -06:00
common-issue.js Add a checkbox to select all issues/PRs (#20177) 2022-07-28 18:25:18 +08:00
common-organization.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
contextpopup.js Refactor from Vue2 to Vue3 (#20044) 2022-10-01 22:26:38 +08:00
dropzone.js Update JS dependencies (#17611) 2021-11-11 09:52:16 +08:00
emoji.js Frontend refactor, PascalCase to camelCase, remove unused code (#17365) 2021-10-21 15:37:43 +08:00
eventsource.sharedworker.js Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) 2022-08-03 22:58:27 +03:00
file-fold.js Allow to mark files in a PR as viewed (#19007) 2022-05-07 20:28:10 +02:00
formatting.js Localize all timestamps (#21440) 2022-10-17 12:08:21 +08:00
heatmap.js Refactor from Vue2 to Vue3 (#20044) 2022-10-01 22:26:38 +08:00
imagediff.js Fix viewed images not loading in a PR (#19919) 2022-06-08 18:19:06 +01:00
install.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
mcaptcha.js Add support mCaptcha as captcha provider (#20458) 2022-08-10 15:20:10 +02:00
notification.js Enable contenthash in filename for dynamic assets (#20813) 2022-08-23 20:58:04 +08:00
org-team.js Never use /api/v1 from Gitea UI Pages (#19318) 2022-04-07 20:59:56 +02:00
pull-view-file.js Replace unstyled meter with progress (#19968) 2022-06-15 12:28:24 +08:00
repo-branch.js Add apply-patch, basic revert and cherry-pick functionality (#17902) 2022-02-09 20:28:55 +00:00
repo-code.js Ignore line anchor links with leading zeroes (#21728) (#21776) 2022-11-11 21:14:16 +08:00
repo-code.test.js Ignore line anchor links with leading zeroes (#21728) (#21776) 2022-11-11 21:14:16 +08:00
repo-commit.js Improve commit status icons (#21124) 2022-09-09 17:03:18 -04:00
repo-common.js Rework repo buttons (#20602) 2022-08-08 02:15:11 +03:00
repo-diff-filetree.js Refactor from Vue2 to Vue3 (#20044) 2022-10-01 22:26:38 +08:00
repo-diff.js Restore function to "Show more" buttons (#22399) (#22426) 2023-01-13 17:29:10 +08:00
repo-editor.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-findfile.js Use weighted algorithm for string matching when finding files in repo (#21370) 2022-10-08 12:22:44 +01:00
repo-findfile.test.js Remove vitest globals (#21505) 2022-10-19 14:50:19 +08:00
repo-graph.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-home.js A minimal change to replace data calls with attr as per guidelines (#19900) 2022-06-06 12:58:53 +08:00
repo-issue-content.js Multiple improvements for comment edit diff (#21990) (#22007) 2022-12-02 15:42:41 -05:00
repo-issue-pr-form.js Refactor from Vue2 to Vue3 (#20044) 2022-10-01 22:26:38 +08:00
repo-issue.js Improve code comment review on mobile (#21461) 2022-10-25 19:11:49 +08:00
repo-legacy.js Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
repo-migrate.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-migration.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-projects.js Fixed colour transparency regex matching in project board sorting (#22092) (#22437) 2023-01-15 12:05:04 +00:00
repo-release.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2022-06-29 01:52:58 +08:00
repo-settings.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2022-06-03 17:38:26 -04:00
repo-template.js Never use /api/v1 from Gitea UI Pages (#19318) 2022-04-07 20:59:56 +02:00
repo-unicode-escape.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
repo-wiki.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2022-06-29 01:52:58 +08:00
serviceworker.js Remove useless `appVer` from JS `window.config` (#21445) 2022-10-14 01:16:27 +08:00
sshkey-helper.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
stopwatch.js Don't display stop watch top bar icon when disabled and hidden when click other place (#22374) (#22387) 2023-01-10 09:21:29 +00:00
tablesort.js Added missing `data-` prefix. (#17884) 2021-12-03 00:36:00 +08:00
tribute.js Correctly escape within tribute.js (#20831) 2022-08-17 15:43:53 -04:00
user-auth-webauthn.js Prevent security failure due to bad APP_ID (#18678) 2022-02-09 15:37:58 +08:00
user-auth.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00
user-settings.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00