forked from gitea/gitea
1
0
Fork 0
gitea/templates
Giteabot 7aafe5e0b4
Fix rendering assignee changed comments without assignee (#27927) (#27952)
Backport #27927 by @invliD

When an assignee changed event comment is rendered, most of it is
guarded behind the assignee ID not being 0. However, if it is 0, that
results in quite broken rendering for that comment and the next one.
This can happen, for example, when repository data imported from outside
of Gitea is incomplete.

This PR makes sure comments with an assignee ID of 0 are not rendered at
all.

---

Screenshot before:
<img width="272" alt="Bildschirm­foto 2023-11-05 um 20 12 18"
src="https://github.com/go-gitea/gitea/assets/42910/7d629d76-fee4-4fe5-9e3a-bf524050cead">
The comments in this screenshot are:
1. A regular text comment
2. A user being unassigned
3. A user being assigned
4. The title of the PR being changed

Comments 2 and 3 are rendered without any text, which indents the next
comment and does not leave enough vertical space.

Co-authored-by: Sebastian Brückner <code@nik.dev>
2023-11-07 22:02:36 +01:00
..
admin cleanup repo details icons/labels (#27644) (#27654) 2023-10-19 22:04:24 +02:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
code Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
devtest Improve dropdown button alignment and fix hover bug (#27632) (#27637) 2023-10-16 16:15:15 +08:00
explore Fix incorrect "tab" parameter for repo search sub-template (#27755) (#27764) 2023-10-24 11:01:26 +08:00
mail Update team invitation email link (#26550) 2023-08-31 16:26:13 +00:00
org Use flex-container for repo and org settings (#27418) (#27430) 2023-10-04 07:20:43 +00:00
package Add dedicated class for empty placeholders (#27788) (#27792) 2023-10-26 09:26:05 +02:00
projects More `db.DefaultContext` refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
repo Fix rendering assignee changed comments without assignee (#27927) (#27952) 2023-11-07 22:02:36 +01:00
shared Always use whole user name as link (#27815) (#27838) 2023-10-30 12:25:40 +01:00
status Clean up template locale usage (#27856) (#27857) 2023-10-31 17:35:55 +01:00
swagger Fix package webhook (#27839) (#27855) 2023-10-31 11:26:28 +01:00
user Feed UI Improvements (#27356) (#27717) 2023-10-21 11:13:15 +00:00
webhook Extract common code to new template (#26933) 2023-09-06 10:11:06 +00:00
home.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
install.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
post-install.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00