forked from gitea/gitea
1
0
Fork 0
gitea/cmd
Lunny Xiao 5f82ead13c
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.

## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:

Firstly, there are temporary repositories which do not change:

```go
git.OpenRepository(ctx, diskPath)
```

Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:

```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```

Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.

## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.

---------

Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 21:09:51 +01:00
..
actions.go Return `responseText` instead of string in some functions (#28836) 2024-01-19 10:45:23 +08:00
admin.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
admin_auth.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
admin_auth_ldap.go Penultimate round of `db.DefaultContext` refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_ldap_test.go Penultimate round of `db.DefaultContext` refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_oauth.go Penultimate round of `db.DefaultContext` refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_stmp.go Penultimate round of `db.DefaultContext` refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_regenerate.go move the `gitea admin` subcommands into separate files (#27307) 2023-09-27 12:25:38 +00:00
admin_user.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_change_password.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_create.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
admin_user_delete.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_generate_access_token.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
admin_user_list.go Reduce usage of `db.DefaultContext` (#27073) 2023-09-14 17:09:32 +00:00
admin_user_must_change_password.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
cert.go Expanded minimum RSA Keylength to 3072 (#26604) 2023-08-28 00:53:16 +00:00
cmd.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
docs.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
doctor.go Move doctor package from modules to services (#28856) 2024-01-20 10:07:31 +08:00
doctor_convert.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) 2024-01-10 11:03:23 +00:00
doctor_test.go Move doctor package from modules to services (#28856) 2024-01-20 10:07:31 +08:00
dump.go fixed duplicate attachments on dump on windows (#28019) 2023-11-14 02:15:45 +01:00
dump_repo.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
embedded.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
generate.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
hook.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
hook_test.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 2023-03-29 14:32:26 +08:00
keys.go Return `responseText` instead of string in some functions (#28836) 2024-01-19 10:45:23 +08:00
mailer.go Return `responseText` instead of string in some functions (#28836) 2024-01-19 10:45:23 +08:00
main.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
manager.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
manager_logging.go Add missing default value for some Bool cli flags (#26082) 2023-07-24 06:49:18 +00:00
migrate.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
migrate_storage.go Fix migrate storage bug (#28830) 2024-01-20 23:27:31 +08:00
migrate_storage_test.go Another round of `db.DefaultContext` refactor (#27103) 2023-09-25 13:17:37 +00:00
restore_repo.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
serv.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
web.go Refactor tests (#26464) 2023-08-12 16:30:16 +00:00
web_acme.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web_graceful.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web_https.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00