forked from gitea/gitea
1
0
Fork 0
gitea/models/db
Earl Warren b748d62b46
Add slow SQL query warning (#27545)
- Databases are one of the most important parts of Forgejo, every
interaction uses the database in one way or another. Therefore, it is
important to maintain the database and recognize when the server is not
doing well with the database. There already is the option to log *every*
SQL query along with its execution time, but monitoring becomes
impractical for larger instances and takes up unnecessary storage in the
logs.
- Add a QoL enhancement that allows instance administrators to specify a
threshold value beyond which query execution time is logged as a warning
in the xorm logger. The default value is a conservative five seconds to
avoid this becoming a source of spam in the logs.
- The use case for this patch is that with an instance the size of
Codeberg, monitoring SQL logs is not very fruitful and most of them are
uninteresting. Recently, in the context of persistent deadlock issues
(https://codeberg.org/forgejo/forgejo/issues/220), I have noticed that
certain queries hold locks on tables like comment and issue for several
seconds. This patch helps to identify which queries these are and when
they happen.
- Added unit test.

(cherry picked from commit 9cf501f1af4cd870221cef6af489618785b71186)

---------

Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
2024-02-23 00:57:24 +00:00
..
install Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
paginator Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
collation.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) 2024-01-10 11:03:23 +00:00
common.go Fix NuGet search endpoints (#25613) 2023-08-14 02:50:55 +00:00
consistency.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
context.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
context_committer_test.go Fix halfCommitter and WithTx (#22366) 2023-01-09 12:19:19 -05:00
context_test.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
convert.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) 2024-01-10 11:03:23 +00:00
engine.go Add slow SQL query warning (#27545) 2024-02-23 00:57:24 +00:00
engine_test.go Rename `Sync2` -> `Sync` (#26479) 2023-08-13 21:17:21 +02:00
error.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
index.go Fix index generation parallelly failure (#25235) 2023-06-15 02:14:43 +02:00
index_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
iterate.go refactor: make db iterate context aware (#27710) 2023-10-21 10:05:29 +08:00
iterate_test.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
list.go Fix joins in `db.Find(AndCount)` (#28978) 2024-01-30 02:37:24 +00:00
list_test.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
log.go Replace `interface{}` with `any` (#25686) 2023-07-04 18:36:08 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
name.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
search.go Split lfs size from repository size (#22900) 2023-06-28 22:41:02 +00:00
sequence.go Refactor `setting.Database.UseXXX` to methods (#23354) 2023-03-07 18:51:06 +08:00
sql_postgres_with_schema.go Fix .golangci.yml (#22868) 2023-02-11 21:44:53 +00:00