forked from gitea/gitea
1
0
Fork 0
gitea/modules/graceful
wxiaoguang 90a3f2d4b7
Avoid unexpected panic in graceful manager (#29629)
There is a fundamental design problem of the "manager" and the "wait
group".
If nothing has started, the "Wait" just panics: sync: WaitGroup is
reused before previous Wait has returned
There is no clear solution besides a complete rewriting of the "manager"

If there are some mistakes in the app.ini, end users would just see the
"panic", but not the real error messages. A real case: #27643

This PR is just a quick fix for the annoying panic problem.
2024-03-06 11:50:39 +00:00
..
releasereopen Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
context.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
manager.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
manager_common.go Suggest to use Type=simple for systemd service (#28717) 2024-01-07 15:18:04 +00:00
manager_unix.go Avoid unexpected panic in graceful manager (#29629) 2024-03-06 11:50:39 +00:00
manager_windows.go Avoid unexpected panic in graceful manager (#29629) 2024-03-06 11:50:39 +00:00
net_unix.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
net_windows.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
restart_unix.go Fix regression: access log template, gitea manager cli command (#24838) 2023-05-22 09:38:38 +08:00
server.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00
server_hooks.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
server_http.go Improve graceful manager code/comment (#28063) 2023-11-15 22:02:46 +08:00