forked from gitea/gitea
1
0
Fork 0
gitea/modules
mrsdizzie 4529a262c0
Don't manually replace whitespace during render (#10291) (#10315)
* Don't manually replace whitespace during render

For historical reasons Gitea manually alters the urlPrefix and replaces
a whitespace with a +. This Works for URLs, but we're also passing
urlPrefix to git calls and adding the + is breaking the tree path.

Goldmark will automatically convert a white space to the proper %20, so
we should leave the string as is which lets us pass it to git unmodified
and then let Goldmark fix it.

Also fixed separate bug in URLJoin I noticed while testing where it will
silently discard sections of a path that have # in them (possibly
others). We should just escape it first.

Fixes 10156

* Escape elems as well

* Revert "Escape elems as well"

This reverts commit 8bf49596fe.

* restart ci

* remove changes to URLJoin

* restart ci

Co-authored-by: techknowlogick <matti@mdranta.net>

Co-authored-by: techknowlogick <matti@mdranta.net>
2020-02-17 19:46:28 +02:00
..
auth Add option to prevent LDAP from deactivating everything on empty search (#9879) (#9896) 2020-01-20 21:18:23 +02:00
avatar
base
cache
charset
context Fix wrong permissions check when issues/prs shared operations (#9885) (#9889) 2020-01-20 17:59:33 +02:00
convert
cron
generate
git Fix commit between two commits calculation if there is only last commit (#10225) (#10226) 2020-02-11 11:10:12 +08:00
gitgraph
graceful Prevent double waitgroup decrement (#10170) (#10175) 2020-02-07 17:12:49 +00:00
highlight
httplib
indexer Stop hanging issue indexer initialisation from preventing shutdown (#10243) (#10249) 2020-02-12 12:22:10 +02:00
lfs
log
markup Don't manually replace whitespace during render (#10291) (#10315) 2020-02-17 19:46:28 +02:00
metrics
migrations
notification Fix check for push on default branch (#9963) 2020-01-24 19:56:30 -05:00
options
password
pprof
private
process
public
queue Fix Workerpool deadlock (#10283) (#10284) 2020-02-15 19:28:25 +00:00
recaptcha
references
repofiles Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch (#9927) (#9974) 2020-01-25 17:39:53 +08:00
repository
secret
session
setting
ssh
structs Fix wrong hint when status checking is running on pull request view (#9886) (#9928) 2020-01-22 08:06:11 +02:00
sync
task
templates
test
timeutil
upload
user
util Sanitize credentials in mirror form (#9975) (#9991) 2020-01-26 08:16:53 +00:00
validation
webhook Fix RocketChat (#9908) (#9921) 2020-01-21 17:24:18 -05:00