test1234
/
gitea
forked from gitea/gitea
1
0
Fork 0
Code Pull Requests Activity

improve unit test for caching (#26185) 

- Configure `setting.CacheService.TTL` which will force the code to go
trough the caching mechanism.
- Remove the TODO and uncomment the test code.

(cherry picked from commit a201f2f1896c1a086f3e37f86b1306d44c07f2e4)

Refs: https://codeberg.org/forgejo/forgejo/pulls/974

---------

Co-authored-by: Gusted <postmaster@gusted.xyz>
This commit is contained in:
Earl Warren 2023-07-27 22:24:40 +02:00 committed by GitHub
parent eaea530d6b
commit 494ee56de2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 37 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
modules/cache/cache_test.go vendored
View File

@ -18,6 +18,7 @@ func createTestCache() {
Adapter: "memory",
TTL: time.Minute,
})
setting.CacheService.TTL = 24 * time.Hour
}
func TestNewContext(t *testing.T) {
@ -54,12 +55,12 @@ func TestGetString(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, "", data)
// data, err = GetString("key", func() (string, error) {
// return "some data", nil
// })
// assert.NoError(t, err)
// assert.Equal(t, "", data)
// Remove("key")
data, err = GetString("key", func() (string, error) {
return "some data", nil
})
assert.NoError(t, err)
assert.Equal(t, "", data)
Remove("key")
data, err = GetString("key", func() (string, error) {
return "some data", nil
@ -67,13 +68,12 @@ func TestGetString(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, "some data", data)
// data, err = GetString("key", func() (string, error) {
// return "", fmt.Errorf("some error")
// })
// assert.NoError(t, err)
// assert.Equal(t, "some data", data)
// TODO: uncommented code works in IDE but not with go test
data, err = GetString("key", func() (string, error) {
return "", fmt.Errorf("some error")
})
assert.NoError(t, err)
assert.Equal(t, "some data", data)
Remove("key")
}
func TestGetInt(t *testing.T) {
@ -91,12 +91,12 @@ func TestGetInt(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, 0, data)
// data, err = GetInt("key", func() (int, error) {
// return 100, nil
// })
// assert.NoError(t, err)
// assert.Equal(t, 0, data)
// Remove("key")
data, err = GetInt("key", func() (int, error) {
return 100, nil
})
assert.NoError(t, err)
assert.Equal(t, 0, data)
Remove("key")
data, err = GetInt("key", func() (int, error) {
return 100, nil
@ -104,13 +104,12 @@ func TestGetInt(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, 100, data)
// data, err = GetInt("key", func() (int, error) {
// return 0, fmt.Errorf("some error")
// })
// assert.NoError(t, err)
// assert.Equal(t, 100, data)
// TODO: uncommented code works in IDE but not with go test
data, err = GetInt("key", func() (int, error) {
return 0, fmt.Errorf("some error")
})
assert.NoError(t, err)
assert.Equal(t, 100, data)
Remove("key")
}
func TestGetInt64(t *testing.T) {
@ -128,12 +127,12 @@ func TestGetInt64(t *testing.T) {
assert.NoError(t, err)
assert.EqualValues(t, 0, data)
// data, err = GetInt64("key", func() (int64, error) {
// return 100, nil
// })
// assert.NoError(t, err)
// assert.EqualValues(t, 0, data)
// Remove("key")
data, err = GetInt64("key", func() (int64, error) {
return 100, nil
})
assert.NoError(t, err)
assert.EqualValues(t, 0, data)
Remove("key")
data, err = GetInt64("key", func() (int64, error) {
return 100, nil
@ -141,11 +140,10 @@ func TestGetInt64(t *testing.T) {
assert.NoError(t, err)
assert.EqualValues(t, 100, data)
// data, err = GetInt64("key", func() (int, error) {
// return 0, fmt.Errorf("some error")
// })
// assert.NoError(t, err)
// assert.EqualValues(t, 100, data)
// TODO: uncommented code works in IDE but not with go test
data, err = GetInt64("key", func() (int64, error) {
return 0, fmt.Errorf("some error")
})
assert.NoError(t, err)
assert.EqualValues(t, 100, data)
Remove("key")
}